Basic support for Airports DLC #1458

krzychu124 · 2022-03-05T18:08:58Z

Support for Airports DLC and Aircrafts/Taxiways in general

vehicle restrictions (passenger plane/ cargo plane)
lane connector (might be disabled after feedback - taxiways have only one vehicle lane)
priority signs (work-in-progress),
speed limits

Update (19/Mar/2022)

slightly improved lane reservation,
increased wait time for planes (they react slower than other vehicles),
improved priority detection for planes,
fixed a bug with speed limit at runway (not final solution)
cargo truck paths recalculation if cargo plane changed target airplane stand

Done

trigger for cargo airplane stand recalculation
BFS search algorithm - better Airplane stand finder
landing behavior improvements
support for Passenger Plane vehicle size restrictions (small/medium/large)

In progress

Passenger Plane vehicle size restriction saving
Passenger Plane vehicle size - Asset Editor extension for vehicles and taxiways

Planned

take-off behavior improvements

I'm thinking about how to implement size restrictions for taxiways/runways(?) (I've got working UI in-progress but I'm not sure how to handle it properly yet)

Dynamic cargo airplane stand selection:

2022-04-28.19-29-53.mp4

Closes #1354

Build zip

added patch for priority check, traffic monitoring and vehicle position update(segment registering)

originalfoo · 2022-03-05T19:25:53Z

Currently runways/taxiways are essentially one-way train tracks, but for planes; if bidirectional taxiways/runways become a thing then lane connectors would be more useful. We'd need something like one-way train AI, but for planes.

For me "vehicle" restrictions are far, far more useful:

aircraft size (tiny, small, medium, large)
- tiny = ~~air tours~~ EDIT: aviation club (sunset harbour) if there's some way to integrate those with airports
- not sure what happens for pre-Airpots DLC aircraft vehicles
aircraft type (cargo, passenger)
- already done in this PR
takeoff (heading to runway) vs. landing (heading to stand)
- do vehicle flags give any indication of whether plane is heading to stand vs. runway?

krzychu124 · 2022-03-05T19:51:03Z

if bidirectional taxiways/runways become a thing then lane connectors would be more useful. We'd need something like one-way train AI, but for planes.

I'm working on it but from what I tested STTAI (modified for taxiways) works only for super simple setups fails completely on slight more advanced ones mostly by causing deadlocks. It requires some sort of signaling process that could manage which vehicle can move and where should stop and wait. Obviously everything is doable, just need a good description what/when - decision tree.

tiny = air tours (sunset harbour) if there's some way to integrate those with airports

Theoretically yes, but I haven't experimented with that. The biggest problem will me ItemClass that defines which aircraft stand vehicle can use.

not sure what happens for pre-Airpots DLC aircraft vehicles

If they are all set as sunset harbor tour vehicles then see above, otherwise, the same as vanilla airplanes they use ItemClass "Medium aircraft"

takeoff (heading to runway) vs. landing (heading to stand)

do vehicle flags give any indication of whether plane is heading to stand vs. runway?

No, what would be the use case?

aircraft size (tiny, small, medium, large)

I plan to add AssetEditor support for more configurable properties (I already listed on trello what is possible to tweak) so the Asset creator could use vanilla ItemClass for vanilla compatible vehicle but with additional UI to alter it and configure more settings. I'm thinking about creating Project to organize things before starting implementation.

originalfoo · 2022-03-05T22:08:15Z

No, what would be the use case?

I sometimes have planes taking v. strange routes as illustrated in image below:

About 80% of time (green line), planes from the large/small stands (top-right of image) go towards the medium stands (top-left of image) on their way to the runway (bottom-left of image) when they should avoid that area completely and use the shorter and more direct route (blue line) which bypasses the medium stands.

The point where the taxiway splits (one branch going to runway, the other to medium stands) would have restrictions so the shorter segment is for "takeoff only" and the longer segment (to medium stands) is for "landing only".

krzychu124 · 2022-03-05T22:13:57Z

About 80% of time (green line), planes from the large/small stands (top-right of image) go towards the medium stands (top-left of image) on their way to the runway (bottom-left of image) when they should avoid that area completely and use the shorter and more direct route (blue line) which bypasses the medium stands.

Hmm, if you notice that only on this build it might be caused by AdvancedAI (it's enabled for aircrafts, I'm still experimenting with DLS) and segment penalties (congestion/traffic usage)

krzychu124 · 2022-03-05T22:54:13Z

tiny = air tours (sunset harbour) if there's some way to integrate those with airports

@aubergine10 ok, I can clone vehicle and swap AI to PassengerPlaneAI on load... but I'm pretty sure that not all SH tour vehicles are tiny

originalfoo · 2022-03-05T23:04:13Z

tiny = air tours (sunset harbour) if there's some way to integrate those with airports

@aubergine10 ok, I can clone vehicle and swap AI to PassengerPlaneAI on load... but I'm pretty sure that not all SH tour vehicles are tiny

Sorry, typo, by tiny I meant aviation club which IIRC are all small?

I think air tours is more relating to hot air balloons or something like that?

krzychu124 · 2022-03-06T01:32:24Z

Looks like it works X D

…nto feature/airports-DLC-support � Conflicts: � TLM/TLM/Util/Extensions/VehicleExtensions.cs

originalfoo · 2022-03-06T15:17:09Z

Hmm, if you notice that only on this build it might be caused by AdvancedAI (it's enabled for aircrafts, I'm still experimenting with DLS) and segment penalties (congestion/traffic usage)

It happens on master branch - although maybe due to lane randomisation of the pathfinder?

In the example cited, another solution might be the aircraft size restrictions - eg. I could prevent small/large aircraft from using medium stands route. However, that's semantically incorrect and it wouldn't be viable on larger / more complex airports; hence the desire to have landing vs. takeoff (arrivals vs. departures?) restrictions. It's a way to limit a taxiway to "going to stand" or "going to runway" even if that taxiway is a viable route for the alternative.

krzychu124 · 2022-03-06T21:49:23Z

I don't know how to detect where vehicle is going and... pathfinding is a play of adding up penalties. I'm not sure how to "suggest" something when PF is calculating score for each lane till find the one is searching (starting point, since PF runs backwards, from finish to the start)

krzychu124 · 2022-03-13T17:15:24Z

I don't know how to detect where vehicle is going...

Argh, I need to figure that out to limit number of unnecessary queries for better aircraft stand since now I use blocked counter - there is no reason to check it when airplane is blocked by traffic when tries to leave the airport

…hey react slower than other vehicles), improved priority detection for planes, fixed a bug with speed limit at runway

…t stand

…nto feature/airports-DLC-support � Conflicts: � TLM/TLM/Manager/Impl/LaneConnectionManager.cs

krzychu124 · 2022-03-19T11:52:19Z

Updated code, PR description, in-progress tasks will be finished either later today or tomorrow,

…s for cargo airplane stand recalculation, changes to speed calulations on the ground, yield stop position changes

krzychu124 · 2022-03-19T15:25:11Z

@aubergine10 I've added few new features, let me know what you think, how it works etc.

krzychu124 · 2022-03-19T19:13:58Z

Work in progress

2022-03-19.19-33-16.mp4

krzychu124 · 2022-04-04T21:03:30Z

@aubergine10 Question about size restrictions. How they should work?
I think there are two ways for testing the size but I'm not sure which is better (don't see how to mix both):

treat size restriction strict (exactly as set, 1:1). The user disabled medium then only medium size vehicles cannot go there
treat setting as a limit of vehicle load that can handle: The user disabled medium then only small and lower can go there (medium, large cannot)

Second option has more sense from asset creator perspective if we allow setting size restriction per asset in the Asset Editor. On the other hand with 1. you can achieve the same as with the 2. Settings does not apply to cargo vehicles since I can't really tell their size (one option would be to set size margins and automatically set the size depends on model of aircraft) 🤷‍♂️

originalfoo · 2022-04-04T22:36:59Z

@krzychu124 I think option 1 is best; at least from my own use case.

For exmaple, I only want medium planes going down a certain taxiway (which leads exclusively to medium stands) and thus want to block both small and large planes on that taxiway. I would not be able to achieve that with option 2.

For asset creators they'd just set whichever restrictions make sense for the size of taxiway/runway, ie. using option 1 to get the effect of option 2.

originalfoo · 2022-04-06T15:01:04Z

TLM/TMPE.API/Traffic/Enums/ExtVehicleFlags.cs

+
+        // aircraft related flags
+        GoingToOutside = 1 << 2,
+        GoingFromOutside = 1 << 3,


Would this be better named ComingFromOutside ?

Also, is there any merit to using existing vehicle flags such as Arriving and Leaving? Or Importing and Exporting?

Arriving and Leaving are temporary flag, Import, Export are related with outside connection transfer.

originalfoo · 2022-04-06T15:49:08Z

TLM/TLM/UI/SubTools/VehicleRestrictionsTool.cs

                maxNumSigns = RoadVehicleTypes.Length;
            } else if (VehicleRestrictionsManager.Instance.IsRailSegment(segmentInfo)) {
                maxNumSigns = RailVehicleTypes.Length;
+            } else if (VehicleRestrictionsManager.Instance.IsPlaneNetInfo(segmentInfo)) {


Inconsistent naming?

Not really but I figure out better name

originalfoo · 2022-04-06T16:25:32Z

TLM/TLM/UI/SubTools/LaneConnectorTool.cs

+                            (connectionClass.m_subService == ItemClass.SubService.PublicTransportMonorail) ||
+                            (connectionClass.m_subService == ItemClass.SubService.PublicTransportPlane)
+                            )))) {


Would this be a lot cleaner and more legible as

connectionClass.m_subservice is ItemClass.SubService.PublicTransportTrain or ItemClass.SubService.PublicTransportMetro or ItemClass.SubService.PublicTransportMonorail or ItemClass.SubService.PublicTransportPlane

TLM/TLM/Manager/Impl/TrafficPriorityManager.cs

originalfoo · 2022-04-14T18:35:36Z

Putting some possible icons for cargo aircraft:

Scissor lifts:

Fork lift trucks:

Elesbaan70 · 2022-04-28T01:41:37Z

@krzychu124 Can you merge the latest master into this branch? It will help me examine your changes, which I want to do as part of making sure my XML Persistence design isn't too specific to traffic lights.

krzychu124 · 2022-04-28T09:42:54Z

Yeah, will do later today 😉

…nto feature/airports-DLC-support � Conflicts: � TLM/TLM/Manager/Impl/LaneConnection/LaneConnectionSubManager.cs � TLM/TLM/UI/SubTools/VehicleRestrictionsTool.cs � TLM/TLM/UI/Textures/RoadUI.cs

Elesbaan70 · 2022-04-29T14:39:08Z

Have you been operating under the assumption that this change would break savegames? Because that was the impression I got, but I'm not sure it will. You might want to check that, because I believe enums are already stored as raw numbers, and I don't see any new types or fields being added.

krzychu124 · 2022-04-29T20:04:59Z

Have you been operating under the assumption that this change would break savegames? Because that was the impression I got, but I'm not sure it will. You might want to check that, because I believe enums are already stored as raw numbers, and I don't see any new types or fields being added.

@Elesbaan70 TL;DR current PR does not introduce any incompatibility yet.

At least not yet. I didn't push changes adding new things to the TMPE savegame data. Currently it only allows to "add" Passenger/CargoPlane enum to vehicle restrictions. Enum values are already available and it shouldn't break anything if you set lane vehicle restriction value with more enum flags (they will be ignored since in previous version of the mod (e.g. current master) there is no handling of those vehicle types - aircraft in general are completely ignored by TM:PE)

I'll push new changes with regards to passenger airplane size restrictions probably tomorrow once I decide how data should look like because I would like to push final solution once, and not change it all the time (I'm lazy and I don't want to remember which savegame requires which mod version 😄 ) in case if you want to try testing your changes to data persistence 😉

BTW, that's why is still Draft PR - things may change or changes are not complete yet.

t1a2l · 2022-10-30T09:38:51Z

@krzychu124 long time since april, where does it stands? what needs still to be done?

Basic support for Airports DLC

e37bf91

krzychu124 self-assigned this Mar 5, 2022

Speed limit calculations,

e8e8bea

added patch for priority check, traffic monitoring and vehicle position update(segment registering)

Merge branch 'master' of https://github.com/CitiesSkylinesMods/TMPE i…

a602834

…nto feature/airports-DLC-support � Conflicts: � TLM/TLM/Util/Extensions/VehicleExtensions.cs

krzychu124 added this to the 11.7.0 milestone Mar 13, 2022

krzychu124 added 6 commits March 13, 2022 20:28

Merge branch 'master' into feature/airports-DLC-support

06d0801

Merge branch 'master' into feature/airports-DLC-support

fcd2a73

merge conflict fix

5d97b2e

Slightly improved lane reservation, increased wait time for planes (t…

2ff3032

…hey react slower than other vehicles), improved priority detection for planes, fixed a bug with speed limit at runway

Cargo truck paths recalculation if cargo plane changed target aircraf…

1281bd7

…t stand

Merge branch 'master' of https://github.com/CitiesSkylinesMods/TMPE i…

db3035b

…nto feature/airports-DLC-support � Conflicts: � TLM/TLM/Manager/Impl/LaneConnectionManager.cs

krzychu124 added 2 commits March 19, 2022 12:36

ExtVehicle extensions

3172f76

Updated game connection delegates

89754af

krzychu124 added 2 commits March 19, 2022 16:04

Airplane Stand Search feature

005fae8

Aircraft Simulation Step patch, improve landing angle(w-i-p), trigger…

4920792

…s for cargo airplane stand recalculation, changes to speed calulations on the ground, yield stop position changes

originalfoo reviewed Apr 6, 2022

View reviewed changes

Merge branch 'master' into feature/airports-DLC-support

21a80cb

originalfoo mentioned this pull request Apr 10, 2022

Chinese theme; Fallback theme; New signs #1523

Merged

krzychu124 mentioned this pull request Apr 20, 2022

Cargo trains (or the cargo) should choose destination station dynamically #1536

Open

krzychu124 added 2 commits April 28, 2022 19:25

temporary plane restriction textures, fixed plane lane routing

0830c69

krzychu124 linked an issue Jun 3, 2022 that may be closed by this pull request

Support for Taxiways and Runways (DLC and non DLC) #1368

Open

krzychu124 added 2 commits June 6, 2022 01:45

Merge branch 'master' into feature/airports-DLC-support

0913aaa

[WiP] Aircraft size restrictions, not saveable yet

91987f5

krzychu124 modified the milestones: 11.8.0, 11.9.0 May 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic support for Airports DLC #1458

Basic support for Airports DLC #1458

krzychu124 commented Mar 5, 2022 •

edited

Loading

originalfoo commented Mar 5, 2022 •

edited

Loading

krzychu124 commented Mar 5, 2022

originalfoo commented Mar 5, 2022 •

edited

Loading

krzychu124 commented Mar 5, 2022

krzychu124 commented Mar 5, 2022

originalfoo commented Mar 5, 2022 •

edited

Loading

krzychu124 commented Mar 6, 2022

originalfoo commented Mar 6, 2022

krzychu124 commented Mar 6, 2022

krzychu124 commented Mar 13, 2022

krzychu124 commented Mar 19, 2022

krzychu124 commented Mar 19, 2022

krzychu124 commented Mar 19, 2022

krzychu124 commented Apr 4, 2022

originalfoo commented Apr 4, 2022

originalfoo Apr 6, 2022

krzychu124 Apr 6, 2022

originalfoo Apr 6, 2022

krzychu124 Apr 6, 2022

originalfoo Apr 6, 2022

originalfoo commented Apr 14, 2022 •

edited

Loading

Elesbaan70 commented Apr 28, 2022

krzychu124 commented Apr 28, 2022

Elesbaan70 commented Apr 29, 2022

krzychu124 commented Apr 29, 2022 •

edited

Loading

t1a2l commented Oct 30, 2022

Basic support for Airports DLC #1458

Are you sure you want to change the base?

Basic support for Airports DLC #1458

Conversation

krzychu124 commented Mar 5, 2022 • edited Loading

Dynamic cargo airplane stand selection:

originalfoo commented Mar 5, 2022 • edited Loading

krzychu124 commented Mar 5, 2022

originalfoo commented Mar 5, 2022 • edited Loading

krzychu124 commented Mar 5, 2022

krzychu124 commented Mar 5, 2022

originalfoo commented Mar 5, 2022 • edited Loading

krzychu124 commented Mar 6, 2022

originalfoo commented Mar 6, 2022

krzychu124 commented Mar 6, 2022

krzychu124 commented Mar 13, 2022

krzychu124 commented Mar 19, 2022

krzychu124 commented Mar 19, 2022

krzychu124 commented Mar 19, 2022

krzychu124 commented Apr 4, 2022

originalfoo commented Apr 4, 2022

originalfoo Apr 6, 2022

Choose a reason for hiding this comment

krzychu124 Apr 6, 2022

Choose a reason for hiding this comment

originalfoo Apr 6, 2022

Choose a reason for hiding this comment

krzychu124 Apr 6, 2022

Choose a reason for hiding this comment

originalfoo Apr 6, 2022

Choose a reason for hiding this comment

originalfoo commented Apr 14, 2022 • edited Loading

Elesbaan70 commented Apr 28, 2022

krzychu124 commented Apr 28, 2022

Elesbaan70 commented Apr 29, 2022

krzychu124 commented Apr 29, 2022 • edited Loading

t1a2l commented Oct 30, 2022

krzychu124 commented Mar 5, 2022 •

edited

Loading

originalfoo commented Mar 5, 2022 •

edited

Loading

originalfoo commented Mar 5, 2022 •

edited

Loading

originalfoo commented Mar 5, 2022 •

edited

Loading

originalfoo commented Apr 14, 2022 •

edited

Loading

krzychu124 commented Apr 29, 2022 •

edited

Loading