Un-invert Options.disableDespawning data byte
#1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the value of `Options.disableDespawning` was historically inverted during de/serialization. This PR fixes that. It's based in part on new `Version` field that Kian put in PR #1211.
originalfoo
added
code cleanup
kvakvs
approved these changes
Mar 12, 2022
krzychu124
requested changes
Mar 12, 2022
4 tasks
|
I'm not sure why I didn't notice it but.... if we are starting "new game", there won't be Configuration data so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the value of
Options.disableDespawningwas historically inverted during de/serialization.This PR fixes that by making the serialized value conistent with how all other options work (not inverted), whilst handling legacy value (inverted) if necessary.
It's based in part on new
Versionfield that @kianzarrin put in PR #1211 (note: if merging prior to that PR, Kian would need to change version in his PR to2).Also fixes some trivial analyzer warnings I noticed.