Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.Unity.Analyzers package to 1.13 #1513

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Update Microsoft.Unity.Analyzers package to 1.13 #1513

merged 2 commits into from
Apr 7, 2022

Conversation

originalfoo
Copy link
Member

Update from 1.7.0 to 1.13.0

microsoft/Microsoft.Unity.Analyzers@1.7.0...1.13.0

UNT0018 onwards are new:

ID Title Category
UNT0018 System.Reflection features in performance critical messages Performance
UNT0019 Unnecessary indirection call for GameObject.gameObject Performance
UNT0020 MenuItem attribute used on non-static method Correctness
UNT0021 Unity message should be protected [opt-in] Correctness
UNT0022 Inefficient method to set position and rotation Performance
UNT0023 Coalescing assignment on Unity objects Correctness
UNT0024 Give priority to scalar calculations over vector calculations Performance
UNT0025 Input.GetKey overloads with KeyCode argument Correctness
UNT0026 GetComponent always allocates Performance

@originalfoo originalfoo added the meta Build environment, github environment, etc. label Apr 4, 2022
@originalfoo originalfoo added this to the 11.6.5.2 milestone Apr 4, 2022
@originalfoo originalfoo self-assigned this Apr 4, 2022
krzychu124
krzychu124 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍 (moar warnings 😂 )

@originalfoo
Copy link
Member Author

bump

@originalfoo originalfoo merged commit cd7dd05 into master Apr 7, 2022
@originalfoo originalfoo deleted the update-ms-unity-analyzers branch April 7, 2022 22:08
@originalfoo originalfoo mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzychu124 krzychu124 krzychu124 approved these changes

@kvakvs kvakvs kvakvs approved these changes

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@originalfoo originalfoo

Labels
meta Build environment, github environment, etc.
Projects
None yet
Milestone
11.6.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@originalfoo @kvakvs @krzychu124