Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hot-reload for DropDownOption #1531

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix hot-reload for DropDownOption #1531

merged 1 commit into from
Apr 13, 2022

Conversation

kianzarrin
Copy link
Collaborator

fixes #1510 (comment)
added null gaurd for UI

@kianzarrin kianzarrin added BUG Defect detected Settings Road config, mod options, config xml lifecycle related to the loading process like enabling/disabling/loading/reloading/load order/hot reload labels Apr 12, 2022
@kianzarrin kianzarrin self-assigned this Apr 12, 2022
@kianzarrin
Copy link
Collaborator Author

hot-reload test passed.

@kianzarrin kianzarrin added this to the 11.6.5.2 milestone Apr 12, 2022
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kianzarrin kianzarrin merged commit c779916 into master Apr 13, 2022
@kianzarrin kianzarrin deleted the 1510-hotreload branch April 13, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected lifecycle related to the loading process like enabling/disabling/loading/reloading/load order/hot reload Settings Road config, mod options, config xml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use SerializableUIOptionBase for all options.
4 participants