Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

routing detector: detail all routings when no target lane #1549

Merged
merged 5 commits into from
Apr 27, 2022
Merged

routing detector: detail all routings when no target lane #1549

merged 5 commits into from
Apr 27, 2022

Conversation

kianzarrin
Copy link
Collaborator

image
when hovering/selecting source lane, all target lanes are highlighted but the hint box did not list them. In this PR I fixed this.

@kianzarrin kianzarrin added enhancement Improve existing feature technical Tasks that need to be performed in order to improve quality and maintainability labels Apr 26, 2022
@kianzarrin kianzarrin self-assigned this Apr 26, 2022
originalfoo
originalfoo approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I hope one day this sort of thing finds its way in to main lane arrows/connnectors tools to help users understand exactly where each lane is leading to, including any lanes they haven't yet customised.

@originalfoo originalfoo added this to the 11.6.5.2 milestone Apr 26, 2022
@originalfoo originalfoo added the LANE ROUTING Feature: Lane arrows / connectors label Apr 26, 2022
krzychu124
krzychu124 requested changes Apr 26, 2022
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No icon -> files not loaded in FullDebug target:

image

Exception not fixed: #1534 (comment)

Other than above, it works. I would add info about hovered lane since it shows ids if nothing is hovered. Maybe also the id of selected lane (might be useful for debugging with log file)

@originalfoo originalfoo mentioned this pull request Apr 26, 2022
Merged
@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Apr 27, 2022 •
edited
Loading

id of the selected lane can be detected using network detective tool.
I only show the ids to resolve ambiguity when there is more than one lane
fixed exception. and sprite.

@kianzarrin kianzarrin requested a review from krzychu124 April 27, 2022 00:27
@kianzarrin kianzarrin merged commit eec1528 into master Apr 27, 2022
@kianzarrin kianzarrin deleted the show-hovered-routings branch April 27, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@kianzarrin kianzarrin

Labels
enhancement Improve existing feature LANE ROUTING Feature: Lane arrows / connectors technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.6.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@kianzarrin @originalfoo @krzychu124