-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotreload save #1635
Hotreload save #1635
Conversation
This feature shouldn't be available on public/release version |
@krzychu124 its only available when hot-reloading. otherwise the code is not executed. |
I understand, but I don't think normal users should be able to use hot-reloading feature. We have features like One more thing, I see that asset data reload will work only if LOM is available, right? |
OK I make it DEBUG only. CS should probably turn off file observers too. but that can be done with LOM patch as well.
Yes. LOM holds the data that needs to be transferred. |
Q: What will happen if I hot-reload different mod after hot-reloading TM:PE (patch is still active)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
This PR applies a patch that forces all data types to use latest TMPE assembly.
First commit: introduce Preload Patch phase
Second commit: hot reload
EDIT: summary from discord talk: