Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pedestrian zone roads have lower priority. #1653

Merged
merged 4 commits into from
Oct 8, 2022
Merged

Conversation

kianzarrin
Copy link
Collaborator

image
in the image above setting high priority road on the junction makes the pedestrian zone road high priority.
it should be the other way around.

@kianzarrin kianzarrin self-assigned this Sep 24, 2022
@kianzarrin kianzarrin marked this pull request as ready for review October 5, 2022 10:58
@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Oct 5, 2022

I didn't find the old cold all that useful. I think the new code is much better. there are 5 class levels which tells the road which tab to go under (technically its determined by UICategory but it is in line with class level).
image

I am open to suggestions though.

@krzychu124
Copy link
Member

Honestly I don't know how to reliably detect "level" of road e.g.: to figure out which should have higher priority etc.
Such thing could help with auto ttl, auto priority rules and probably a lot more things. There was a suggestion about either auto priorities or auto traffic lights but I can't find (maybe I just have no luck in search keyword 😄 )

@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Oct 7, 2022

@krzychu124 Such thing could help with auto ttl, auto priority rules and probably a lot more things. There was a suggestion about either auto priorities or auto traffic lights but I can't find (maybe I just have no luck in search keyword 😄 )

Just look at my code. I use class level. its just an enum from level0 to level5

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kianzarrin kianzarrin merged commit 85dbdf3 into master Oct 8, 2022
@kianzarrin kianzarrin deleted the priority-road-fix branch October 8, 2022 21:27
@krzychu124 krzychu124 added this to the 11.8.0 milestone Oct 10, 2022
@krzychu124 krzychu124 modified the milestones: 11.8.0, 11.7.2.0 Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants