Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parking AI - thinking about a parking spot bugfix #1661

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Sep 28, 2022

Fixes #1655

  • added missing vehicle category for Parking AI pathfinding parameters,
  • ignore pedestrian zone roads when searching for driving-only passenger car path when Parking AI is enabled
  • minor logging changes

Build ZIP

… pedestrian zone roads when searching for driving-only passenger car path
@krzychu124 krzychu124 added BUG Defect detected STABLE TM:PE STABLE branch PARKING Feature: Parking AI / restrictions / etc PATHFINDER Pathfinding tweaks or issues TEST TEST version of the mod / workshop page labels Sep 28, 2022
@krzychu124 krzychu124 added this to the 11.7.1 milestone Sep 28, 2022
@krzychu124 krzychu124 self-assigned this Sep 28, 2022
@chameleon-tbn
Copy link
Contributor

  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.get_tooltipBox () [0x00000] in <filename unknown>:0 
  at ColossalFramework.UI.UIComponent.RefreshTooltip () [0x00000] in <filename unknown>:0 
  at TrafficManager.UI.Helpers.SliderOption.UpdateTooltip () [0x00000] in <filename unknown>:0 
  at TrafficManager.UI.Helpers.SliderOption.AddUI (UIHelperBase container) [0x00000] in <filename unknown>:0 
  at TrafficManager.State.GeneralTab_InterfaceGroup.AddUI (UIHelperBase tab) [0x00000] in <filename unknown>:0 
  at TrafficManager.State.GeneralTab.MakeSettings_General (TrafficManager.UI.Helpers.ExtUITabstrip tabStrip) [0x00000] in <filename unknown>:0 
  at TrafficManager.State.Options.MakeSettings (.UIHelper helper) [0x00000] in <filename unknown>:0 
UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object)
UnityEngine.DebugLogHandler:LogException(Exception, Object)
UnityEngine.Logger:LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
TrafficManager.Util.Shortcuts:LogException(Exception, Boolean)
TrafficManager.State.Options:MakeSettings(UIHelper)
TrafficManager.Lifecycle.TrafficManagerMod:OnSettingsUI(UIHelper)
System.Reflection.MonoMethod:InternalInvoke(Object, Object[], Exception&)
System.Reflection.MonoMethod:Invoke(Object, BindingFlags, Binder, Object[], CultureInfo)
System.Reflection.MethodBase:Invoke(Object, Object[])
OptionsMainPanel:OptionsMainPanel.AddUserMods_Patch2(OptionsMainPanel)
OptionsMainPanel:CreateCategories()
OptionsMainPanel:Awake()
UnityEngine.Object:Internal_CloneSingle(Object)
UnityEngine.Object:Instantiate(GameObject)
ColossalFramework.UI.UIDynamicPanels:Init(UIView)
ColossalFramework.UI.UIView:Awake()```

@krzychu124
Copy link
Member Author

@kianzarrin did you fix it (@chameleon-tbn error) when replaced tooltip with value displayed in the label?

@krzychu124 krzychu124 mentioned this pull request Oct 2, 2022
1 task
@kianzarrin
Copy link
Collaborator

what is driving only path?

@krzychu124
Copy link
Member Author

what is driving only path?

The last phase of the path -> when citizen reaches the last position of original path and found the parking spot - the request for path to parking spot has DrivingOnly flag since it has to be passenger car path directly from current position to the parking spot.

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm
ingame it seems to work as expected. not tested all edge cases that might be possible though.

@krzychu124 krzychu124 merged commit a61184a into master Oct 4, 2022
@krzychu124 krzychu124 deleted the bugfix/parking-ai-stuck-vehicles-pathfinding-bug branch October 4, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected PARKING Feature: Parking AI / restrictions / etc PATHFINDER Pathfinding tweaks or issues STABLE TM:PE STABLE branch TEST TEST version of the mod / workshop page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plaza and Pedestrian Zones have broke Realistic Parking Feature
3 participants