Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: dead end connection becomes disabled when removed. #1679

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Oct 15, 2022

fixes #1678
code is simple and self explanatory.

changes:

  • added extra condition to handle removal of special case of dead end.
  • improved lane assertion to check for disabled dead end.

TMPE.zip

I Tested the code like this:

  • make and remove dead end connection
  • then make and remove connection to another track
  • then make connection to the other track and remove it by making a dead end connection.
  • then make a dead end connection and remove it by making connection to the other track
    expected result:
  • tracks are connected and disconnected as expected
  • no assertion/exception/error in the log.

Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, no errors in log, worked as expected

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all seem to work as expected. 👍

@kianzarrin
Copy link
Collaborator Author

@krzychu124 can you please push a hotfix for this?

@kianzarrin kianzarrin merged commit 852d2d8 into master Oct 16, 2022
@kianzarrin kianzarrin deleted the dead-end-fix branch October 16, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected high priority Affects lots of users LANE ROUTING Feature: Lane arrows / connectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dead end connection disabled but not removed
4 participants