-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't save empty records in asset editor #1681
Conversation
ee55f0c
to
c7f189c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
How big is empty data record?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, question is: Is it backward compatible with existing Move It exports, e.g. those from Allbuilds.org? I mean bool
to bool?
change 🤔
@krzychu124 good point. I saved traffic light move it record with old TMPE and loaded with new TMPE and it worked! both off and on state. |
Its redundant to add TM:PE data to an asset when there are no TM:PE rules. This redundancy has some downsides:
All this inconvenience can be avoided by not recording Traffic rules if there is none.
Changes:
bool ?Get/SetHasTrafficLights()
which returns null/resets if traffic light value is not forced.IsDefault()
toIRecordables
TMPE.zip