considerate bus stop behaviour

[kianzarrin]

fixes #1688. see issue for details
TMPE.zip

[krzychu124]

I've tested with bus, trolleybus, and trams (obviously shouldn't change anything, but just in case), everything seems to be working nicely. Noticeably better than vanilla. Performance wise most likely in margin of error territory which is nice.

One thing I noticed, but I haven't had time to compare it to scenario without the change is that when you put bus stop at segment joined directly to big intersection node busses going from other segment may overshoot stop position and run into each other instead of forming a waiting queue especially if they are turning from different direction.

ugly example when approaching green bus is not able to stop without hitting blue bus that is already waiting at the bus stop

[kianzarrin]

@krzychu124 if you have a test city I'd like to take a look. I'd be surprised if my changes do anything to contribute to this situation since I am only changing the sideways position by a little bit.

[krzychu124]

@krzychu124 if you have a test city I'd like to take a look. I'd be surprised if my changes do anything to contribute to this situation since I am only changing the sideways position by a little bit.

Yeah, but maybe changes to path are increasing a chance to collision detection issues e.g.: because target positions are generated differently further exposing its poor accuracy at high speed

[kianzarrin]

@krzychu124 do you have saved city? it might be hard to reproduce

[krzychu124]

@krzychu124 do you have saved city? it might be hard to reproduce

Yeah, I have, but I don't see any difference between this build and current master (on both sometimes they do weird things) so I think we can ignore that for now.

[kianzarrin]

t1 and t2 should be modifiable : #1695