Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Dropdown - prevent unwanted option change on mouse wheel scrool #1733

Merged

Conversation

krzychu124
Copy link
Member

Fixes #1379

  • CustomDropDown component for custom handling of the mouse wheel behavior over closed dropdown control,
  • swapped vanilla control with custom to prevent unwanted changing selected dropdown option while scrolling the page - the reason why some users reported changing language to Arabic
  • Besides the change in mouse wheel behavior on closed dropdown, it looks and works exactly like before (I've had to maually setup the control)

Build ZIP

…unwanted changing selected dropdown option while scrolling the page
@krzychu124 krzychu124 added Usability Make mod easier to use UI User interface updates Settings Road config, mod options, config xml labels Mar 21, 2023
@krzychu124 krzychu124 added this to the 11.7.4.0 milestone Mar 21, 2023
@krzychu124 krzychu124 self-assigned this Mar 21, 2023
@krzychu124
Copy link
Member Author

I've added fix for memory leak and reduced number of instances created since for Dropdown the scrollbar stored under listScrollbar property is used as a template to generate a clone of scrollbar for popup window with options, so we can safely share a single instance across all components where needed, but needs to be destroyed manually between loading scenes, and it cannot be attached to component tree for automated lifecycle managment because layout breaks (attached component takes up the space...), hence why such weird construct (template is destroyed with first destroyed dropdown). 😕
I'll figure out better way of handling such case, since I saw more usecases but for now it works good enough for our needs.

@krzychu124 krzychu124 merged commit be0f6e3 into master Mar 22, 2023
@krzychu124 krzychu124 deleted the improvement/customizable-scroll-behavior-closed-dropdown branch March 22, 2023 08:52
@krzychu124 krzychu124 mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Settings Road config, mod options, config xml UI User interface updates Usability Make mod easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some users report language defaulting to Arabic
2 participants