New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Harmony savegame compat with the pre-Harmony master #427

Merged

krzychu124 merged 2 commits into CitiesSkylinesMods:119-migration-to-harmony-merged from kvakvs:119-migration-to-harmony-savegamefix

Jul 15, 2019

Collaborator

kvakvs commented Jul 14, 2019

Note to reviewers

Please use ⚙️ Ignore whitespace option

Contents

Restored old ExtVehicleType enum, marked it obsolete
Visited every field using it, marked them obsolete
Moved all enum stuff in TMPE.API into API namespace
Added conversions where it is needed
Savegame now continues using the old enum, while game runs mostly (not 100%) with the new


          Moved type and old legacy type given different namespaces

9b3996c

kvakvs requested review from originalfoo and krzychu124

July 14, 2019 23:29


          ConfigData members and Config untabified

6ec4c8c

krzychu124 approved these changes

View reviewed changes

Member

krzychu124 left a comment

I've tested loading and saving using this PR build.
Savegame mod data is loaded properly using this build as well as current master/labs
👍

Member

originalfoo commented Jul 15, 2019

Just about to test....

originalfoo approved these changes

View reviewed changes

Member

originalfoo left a comment

👍 LGTM

originalfoo added the technical label

originalfoo added this to the 11.0 milestone

krzychu124 merged commit 7948df5 into CitiesSkylinesMods:119-migration-to-harmony-merged

originalfoo added the Harmony label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Harmony technical