Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TinyDictionaryUnitTest - code cleanup #476

Merged
merged 1 commit into from
Aug 3, 2019
Merged

TinyDictionaryUnitTest - code cleanup #476

merged 1 commit into from
Aug 3, 2019

Conversation

originalfoo
Copy link
Member

Cleaned up code to rid some of the build warnings.

@originalfoo originalfoo added technical Tasks that need to be performed in order to improve quality and maintainability code cleanup Refactor code, remove old code, improve maintainability labels Aug 3, 2019
@originalfoo originalfoo added this to the 11.0 milestone Aug 3, 2019
@originalfoo originalfoo requested a review from kvakvs August 3, 2019 18:30
@originalfoo originalfoo self-assigned this Aug 3, 2019
kvakvs
kvakvs approved these changes Aug 3, 2019
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty

krzychu124
krzychu124 approved these changes Aug 3, 2019
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@originalfoo originalfoo merged commit a5a0218 into master Aug 3, 2019
@originalfoo originalfoo deleted the tiny-test-cleanup branch August 3, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

Assignees

@originalfoo originalfoo

Labels
code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@originalfoo @kvakvs @krzychu124