Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed junction manger OnLevelUnloading() #637

Merged
merged 2 commits into from
Feb 2, 2020

Conversation

kianzarrin
Copy link
Collaborator

fixes #636

Fixed junction manger OnLevelUnloading() is now fixed to reset both ends of the segment.

@kianzarrin
Copy link
Collaborator Author

This is a stability fix that should go into TMPE LABS as well.

@originalfoo originalfoo added this to the 11.0 milestone Feb 2, 2020
@originalfoo originalfoo added the technical Tasks that need to be performed in order to improve quality and maintainability label Feb 2, 2020
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't spot any adverse side effects. LGTM 👍

@originalfoo originalfoo changed the title 636 unload jm Fixed junction manger OnLevelUnloading() Feb 2, 2020
@originalfoo originalfoo merged commit 7c47546 into CitiesSkylinesMods:master Feb 2, 2020
@kianzarrin kianzarrin deleted the 636-unload-JM branch February 3, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Junction manager fails to remove some rules when unloading
4 participants