Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixMissingNoiseDensityLogic #76

Merged
merged 1 commit into from
Feb 13, 2019
Merged

FixMissingNoiseDensityLogic #76

merged 1 commit into from
Feb 13, 2019

Conversation

pcfantasy
Copy link
Contributor

Fix Missing Noise Density Logic bettween TMPE and Vanilla game in RoadAI.SimulationStep

See details in:
#66

@originalfoo
Copy link
Member

I assume this takes in to account the noise factor of the road type (and some other part of the game applies tree-based noise reduction)?

@krzychu124 krzychu124 self-requested a review February 13, 2019 19:12
krzychu124
krzychu124 approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krzychu124 krzychu124 merged commit fcc34bb into CitiesSkylinesMods:master Feb 13, 2019
@pcfantasy
Copy link
Contributor Author

@aubergine10

In vanilla code, noiseDensity is a new variable in new version, in old version this variable is not exist and use trafficDensity to caculation addtion noise pollution.

For noise pollution now, it simply like noiseDensity * road type. noiseDensity is related to vehicle type and trafficDensity.

@originalfoo originalfoo added this to the 1.10.16 milestone Feb 14, 2019
@originalfoo originalfoo added the enhancement Improve existing feature label Feb 16, 2019
@originalfoo originalfoo mentioned this pull request Mar 2, 2019
Open
@originalfoo originalfoo added the technical Tasks that need to be performed in order to improve quality and maintainability label Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzychu124 krzychu124 krzychu124 approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing feature technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
1.10.16
Development

Successfully merging this pull request may close these issues.
3 participants
@pcfantasy @originalfoo @krzychu124