Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skytools benchmark #907

Merged
merged 7 commits into from
May 27, 2020
Merged

Skytools benchmark #907

merged 7 commits into from
May 27, 2020

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented May 23, 2020

  • removed old benchmark code
  • added skytools benchmark
  • removed old 'benchmark' solution config
  • added new 'benchmark' solution config that is based on a default release config, just with the 'BENCHMARK' symbol and without the 'TRACE' symbol.

@originalfoo originalfoo added performance Make it faster! code cleanup Refactor code, remove old code, improve maintainability labels May 23, 2020
@originalfoo originalfoo added this to the 11.6.0 milestone May 23, 2020
originalfoo
originalfoo reviewed May 23, 2020
View reviewed changes
TLM/TLM/TLM.csproj Outdated Show resolved Hide resolved
@originalfoo originalfoo added the DO NOT MERGE YET Don't merge this PR, even if approved, until further notice label May 23, 2020
@originalfoo
Copy link
Member

Flagging as 'do not merge yet'; #866 (Harmony 2 migration) should get merged first.

@originalfoo
Copy link
Member

@DaEgi01 posted this via discord; might be useful for anyone testing this PR:

to test the skytools benchmark, switch to benchmark solution config, rebuild, start game, wait some time in game, then exit to main menu (exit to desktop does not work atm xD) you should see the numbers in output_log.txt

@originalfoo originalfoo removed the DO NOT MERGE YET Don't merge this PR, even if approved, until further notice label May 24, 2020
@DaEgi01
Merge branch 'master' into skytools-benchmark
e9b41dc 
# Conflicts:
#	TLM/TLM/LoadingExtension.cs
#	TLM/TLM/Patch/_RoadBaseAI/SegmentSimulationStepPatch.cs
#	TLM/TLM/TLM.csproj
#	TLM/TLM/packages.config
@DaEgi01
Copy link
Contributor Author

DaEgi01 commented May 24, 2020

updated the branch with master. works fine on harmony 2 :)
benchmarking could and should be improved, but I think this is an ok start.

originalfoo
originalfoo approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

krzychu124
krzychu124 approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@DaEgi01 DaEgi01 merged commit e92568b into master May 27, 2020
@DaEgi01 DaEgi01 deleted the skytools-benchmark branch May 27, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzychu124 krzychu124 krzychu124 approved these changes

@originalfoo originalfoo originalfoo approved these changes

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

@kvakvs kvakvs Awaiting requested review from kvakvs

Assignees

@DaEgi01 DaEgi01

Labels
code cleanup Refactor code, remove old code, improve maintainability performance Make it faster!
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DaEgi01 @originalfoo @krzychu124