Disable openid_connect role mapping #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was fixed in https://www.drupal.org/project/openid_connect/issues/3492759. Some of our projects have lingering configuration, so the module started to eat user roles. Helfi should not use openid_connect role mapping, since we have custom implementation.
hyrsky
force-pushed
the
UHF-X-kasko-role-mapping
branch
from
7acb66a to
27afe21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
============================================
+ Coverage 95.89% 96.17% +0.27%
- Complexity 56 69 +13
============================================
Files 4 5 +1
Lines 195 235 +40
============================================
+ Hits 187 226 +39
- Misses 8 9 +1 ☔ View full report in Codecov by Sentry. |
tuutti
approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenID connect role mapping feature was fixed in https://www.drupal.org/project/openid_connect/issues/3492759. Some of our projects have lingering configuration for this feature, so the module started to eat user roles. Helfi should not use openid_connect role mapping, since we have custom implementation.
How to test
composer require drupal/helfi_tunnistamo:dev-UHF-X-kasko-role-mappingdrush updbdrush php:eval "print_r(Drupal::configFactory()->get('openid_connect.settings')->get('role_mappings'))", should return empty array.