Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI-3295 Add attachments page to kaivuilmoitus taydennys form #1033

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

markohaarni
Copy link
Contributor

Description

Attachments page shows original attachments added to kaivuilmoitus. It's also possible to add new attachments and remove those.

Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-3295

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

  1. Try to add attachments to kaivuilmoitus täydennys
  2. Check that possible original attachments are shown also

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

Other relevant info

Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

Base automatically changed from HAI-428/edit-kaivuilmoitus-taydennys to dev January 9, 2025 07:19
@markohaarni markohaarni force-pushed the HAI-3295/kaivuilmoitus-taydennys-attachments branch from c645dba to 7e28ba8 Compare January 9, 2025 07:41
Attachments page shows original attachments added to kaivuilmoitus.
It's also possible to add new attachments and remove those.
@markohaarni markohaarni force-pushed the HAI-3295/kaivuilmoitus-taydennys-attachments branch from 7e28ba8 to 64c9911 Compare January 9, 2025 10:52
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
9.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@umeetiusbaar umeetiusbaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as described. Code looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants