Verkkokauppa refactoring #1111
Merged
Verkkokauppa refactoring #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranta
force-pushed
the
verkkokauppa-refactoring
branch
2 times, most recently
from
1b84dab to
0c0cee5
Compare
matti-lamppu
requested changes
Feb 15, 2024
matti-lamppu
approved these changes
Feb 22, 2024
- This was an old 'Proof of Concept' that was deemed as unnecessary - Update dependencies
- Sending an empty first or last customer name causes an error in Verkkokauppa
- Combine few almost-duplicate-tests together
ranta
force-pushed
the
verkkokauppa-refactoring
branch
from
0c0cee5 to
b84bd3a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
🧪 Test plan
🎫 Tickets