Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verkkokauppa API urls #1122

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix verkkokauppa API urls #1122

merged 2 commits into from
Feb 29, 2024

Conversation

ranta
Copy link
Collaborator

@ranta ranta commented Feb 29, 2024

🛠️ Changelog

  • The endpoints which URLs are only VERKKOKAUPPA_*_API_URL should have a '/' at the end

🧪 Test plan

  • Manual testing without mock verkkokauppa

🎫 Tickets

  • TILA-3066

- The endpoints which URLs are only VERKKOKAUPPA_*_API_URL should have a '/' at the end
@ranta ranta requested a review from matti-lamppu February 29, 2024 13:43
- Changed to use `json` instead of `data` as it automatically sets it and does not require converting dicts to json before
@ranta ranta enabled auto-merge (rebase) February 29, 2024 14:22
Copy link

@ranta ranta merged commit c79910c into main Feb 29, 2024
5 checks passed
@ranta ranta deleted the fix-verkkokauppa-url branch February 29, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants