Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5 fixes #1129

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Django 5 fixes #1129

merged 6 commits into from
Mar 12, 2024

Conversation

ranta
Copy link
Collaborator

@ranta ranta commented Mar 11, 2024

🛠️ Changelog

  • Fix Django Admin logout button
  • Remove removed USE_L10N setting
  • Use SESSION_SERIALIZER from django-helusers

🧪 Test plan

  • Automated tests
  • Try logging in locally with tunnistamo credentials

🎫 Tickets

  • None

ranta added 3 commits March 11, 2024 19:44
- Support for logging out via GET requests in the django.contrib.auth.views.LogoutView and django.contrib.auth.views.logout_then_login() was deprecated in Django 4 and removed in Django 5.0
@ranta ranta added fix Fixes a bug refactor Refactors something labels Mar 11, 2024
@ranta ranta requested a review from matti-lamppu March 11, 2024 17:52
Copy link
Collaborator

@matti-lamppu matti-lamppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check how the sessions behave after the serializer change, though I don't think there is much we can do other than be aware of what the impact is.

@ranta ranta enabled auto-merge (rebase) March 12, 2024 15:02
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ranta ranta merged commit 9729bbf into main Mar 12, 2024
5 checks passed
@ranta ranta deleted the django5-fixes branch March 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug refactor Refactors something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants