Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space app admin panel #1255

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Fix space app admin panel #1255

merged 2 commits into from
Jun 27, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Jun 27, 2024

🛠️ Changelog

  • Fixes admin panel crashing when loading an individual space.
  • Refactors the spaces admin panel to individual files,
  • Removes unused models from admin panel (i.e. Building, RealEstate, ...)

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

@matti-lamppu matti-lamppu added the fix Fixes a bug label Jun 27, 2024
@matti-lamppu matti-lamppu self-assigned this Jun 27, 2024
@matti-lamppu matti-lamppu requested a review from vergama June 27, 2024 07:42
@matti-lamppu matti-lamppu marked this pull request as ready for review June 27, 2024 07:43
@matti-lamppu matti-lamppu requested a review from ranta June 27, 2024 08:20
@matti-lamppu
Copy link
Collaborator Author

Merged #1256 to this

Only display the buttons in list of form views depending on
which it is intended to work in.
@matti-lamppu matti-lamppu force-pushed the fix-admin-panel-spaces branch from 24f2fb4 to 65da25e Compare June 27, 2024 09:59
Copy link

@matti-lamppu
Copy link
Collaborator Author

/fast-forward

Copy link

Triggered from #1255 (comment) by @​matti-lamppu.

Trying to fast forward main (991198c) to fix-admin-panel-spaces (65da25e).

Target branch (main):

commit 991198cc0e37214a9146517849f46d5deff6362c (HEAD -> main, tag: v0.51.2, origin/main, origin/HEAD)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Thu Jun 27 09:42:35 2024 +0300

    Change RejectedOccurrenceFilterSet filters to accept multiple values

Pull request (fix-admin-panel-spaces):

commit 65da25eb26cba7cf761e44175e949fbc72fe2b66 (pull_request/fix-admin-panel-spaces)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Thu Jun 27 11:15:01 2024 +0300

    Fix admin panel buttons not working in some cases
    
    Only display the buttons in list of form views depending on
    which it is intended to work in.

Fast forwarding main (991198c) to fix-admin-panel-spaces (65da25e).

$ git push origin 65da25eb26cba7cf761e44175e949fbc72fe2b66:main
To https://github.com/City-of-Helsinki/tilavarauspalvelu-core.git
   991198cc..65da25eb  65da25eb26cba7cf761e44175e949fbc72fe2b66 -> main

@github-actions github-actions bot merged commit 65da25e into main Jun 27, 2024
6 checks passed
@github-actions github-actions bot deleted the fix-admin-panel-spaces branch June 27, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants