Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix section status #1260

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fix section status #1260

merged 2 commits into from
Jul 4, 2024

Conversation

ranta
Copy link
Collaborator

@ranta ranta commented Jul 3, 2024

🛠️ Changelog

  • Fix ApplicationSection.status in cases where all reservation unit options were locked/rejected but it still had allocated slots
  • Fix generating reservations for allocated slots that end at midnight

🧪 Test plan

  • Automated tests
  • Manual testing is probably good also

🚧 Dependencies

  • None

🎫 Tickets

ranta added 2 commits July 3, 2024 17:13
- Fixes a case found in manual testing, where a section, which had only one option, was allocated some slots (but not all), and then it was locked, which caused the status to incorrectly be REJECTED, instead of HANDLED.
- Fixes an issue found in manual testing, when trying to complete an application round
Copy link

sonarqubecloud bot commented Jul 3, 2024

@ranta ranta merged commit 309a689 into main Jul 4, 2024
6 checks passed
@ranta ranta deleted the fix-section-status branch July 4, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant