Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ECR for pulling docker images #1275

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Aug 2, 2024

🛠️ Changelog

  • This is done due to hitting pull rate limits for Docker Hub (for unauthenticated users) in Azure Pipelines. At the time, this is 100 pulls per 6 hours, which is shared with all Platta developers. ECR offers 1 pull per second (for unauthenticated users), which we shouldn't hit too often since CI also has retries for pulling images.

🧪 Test plan

  • Builds should work in GitHub CI and Azure Pipelines

🚧 Dependencies

  • None

🎫 Tickets

  • None

@matti-lamppu matti-lamppu added the fix Fixes a bug label Aug 2, 2024
@matti-lamppu matti-lamppu self-assigned this Aug 2, 2024
@matti-lamppu matti-lamppu requested a review from vergama August 2, 2024 08:22
Copy link

github-actions bot commented Aug 2, 2024

Triggered from #1275 by @​matti-lamppu.

Checking if we can fast forward main (ed7b8cf) to use-ecr-docker (41abc70).

Target branch (main):

commit ed7b8cfda646e6cf20de4d0016668ed4310f46a6 (HEAD -> main, origin/main, origin/HEAD)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Thu Aug 1 12:24:37 2024 +0300

    Add a warning for using test data creation in production environment

Pull request (use-ecr-docker):

commit 41abc702a32e8fb7e1cc434b984518ae3eb5dd3a (pull_request/use-ecr-docker)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Fri Aug 2 11:21:06 2024 +0300

    Switch to ECR for pulling docker images
    
    This is done due to hitting pull rate limits for Docker Hub
    (for unauthenticated users) in Azure Pipelines. At the time,
    this is 100 pulls per 6 hours, which is shared with all platta
    developers. ECR offers 1 pull per second (for unauthenticated users),
    which we shouldn't hit too often, since CI also has retries for
    pulling images.

Can't fast forward main (ed7b8cf) to use-ecr-docker (41abc70). main (ed7b8cf) is not a direct ancestor of use-ecr-docker (41abc70). Branches appear to have diverged at 09c30da:

* 41abc702a32e8fb7e1cc434b984518ae3eb5dd3a Switch to ECR for pulling docker images
| * ed7b8cfda646e6cf20de4d0016668ed4310f46a6 Add a warning for using test data creation in production environment
| * c26a4c0a2937ec6e5198672dd9d1ff6bfa2e48b5 Add `allow_cascade=True` to test data creation flush
|/  
* 09c30daeba5cdc89c9a8f97e5f0f9c0bc6ab7b15 Add another option for fast-forward merge comment

commit 09c30daeba5cdc89c9a8f97e5f0f9c0bc6ab7b15 (tag: v0.53.1)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Wed Jul 31 12:31:29 2024 +0300

    Add another option for fast-forward merge comment

Rebase locally, and then force push to use-ecr-docker.

This is done due to hitting pull rate limits for Docker Hub
(for unauthenticated users) in Azure Pipelines. At the time,
this is 100 pulls per 6 hours, which is shared with all platta
developers. ECR offers 1 pull per second (for unauthenticated users),
which we shouldn't hit too often, since CI also has retries for
pulling images.
Copy link

sonarqubecloud bot commented Aug 2, 2024

@matti-lamppu matti-lamppu marked this pull request as ready for review August 2, 2024 11:06
@matti-lamppu
Copy link
Collaborator Author

/ff

Copy link

github-actions bot commented Aug 2, 2024

Triggered from #1275 (comment) by @​matti-lamppu.

Trying to fast forward main (ed7b8cf) to use-ecr-docker (1ee0c87).

Target branch (main):

commit ed7b8cfda646e6cf20de4d0016668ed4310f46a6 (HEAD -> main, origin/main, origin/HEAD)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Thu Aug 1 12:24:37 2024 +0300

    Add a warning for using test data creation in production environment

Pull request (use-ecr-docker):

commit 1ee0c8758afa804960d9424e0b7fd56124405d77 (pull_request/use-ecr-docker)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Fri Aug 2 11:21:06 2024 +0300

    Switch to ECR for pulling docker images
    
    This is done due to hitting pull rate limits for Docker Hub
    (for unauthenticated users) in Azure Pipelines. At the time,
    this is 100 pulls per 6 hours, which is shared with all platta
    developers. ECR offers 1 pull per second (for unauthenticated users),
    which we shouldn't hit too often, since CI also has retries for
    pulling images.

Fast forwarding main (ed7b8cf) to use-ecr-docker (1ee0c87).

$ git push origin 1ee0c8758afa804960d9424e0b7fd56124405d77:main
To https://github.com/City-of-Helsinki/tilavarauspalvelu-core.git
   ed7b8cfd..1ee0c875  1ee0c8758afa804960d9424e0b7fd56124405d77 -> main

@github-actions github-actions bot merged commit 1ee0c87 into main Aug 2, 2024
6 checks passed
@github-actions github-actions bot deleted the use-ecr-docker branch August 2, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants