Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating reservation statistics when creating seasonal bookings #1283

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

matti-lamppu
Copy link
Collaborator

🛠️ Changelog

  • See title. Move the code creating the statistics outside the transaction block.

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

Move the code creating the statistics outside the transaction block
@matti-lamppu matti-lamppu added the fix Fixes a bug label Aug 8, 2024
@matti-lamppu matti-lamppu requested review from vergama and ranta August 8, 2024 11:11
@matti-lamppu matti-lamppu self-assigned this Aug 8, 2024
Copy link

sonarqubecloud bot commented Aug 8, 2024

@matti-lamppu matti-lamppu marked this pull request as ready for review August 8, 2024 11:29
@matti-lamppu
Copy link
Collaborator Author

/ff

Copy link

github-actions bot commented Aug 8, 2024

Triggered from #1283 (comment) by @​matti-lamppu.

Trying to fast forward main (d919059) to fix-statistics-creation-for-seasonal-booking (ea65cf1).

Target branch (main):

commit d919059a7868807049f91fef09c5b9989283fa5a (HEAD -> main, tag: v0.54.1, origin/main, origin/HEAD)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Thu Aug 8 13:25:52 2024 +0300

    Fix a bug in first reservable time calc pagination optimization

Pull request (fix-statistics-creation-for-seasonal-booking):

commit ea65cf133e7711026ae1eb002ede157bd8ffcb04 (pull_request/fix-statistics-creation-for-seasonal-booking)
Author: Matti Lamppu <matti.lamppu@vincit.fi>
Date:   Thu Aug 8 14:11:08 2024 +0300

    Fix creating reservation statistics when creating seasonal bookings
    
    Move the code creating the statistics outside the transaction block

Fast forwarding main (d919059) to fix-statistics-creation-for-seasonal-booking (ea65cf1).

$ git push origin ea65cf133e7711026ae1eb002ede157bd8ffcb04:main
To https://github.com/City-of-Helsinki/tilavarauspalvelu-core.git
   d919059a..ea65cf13  ea65cf133e7711026ae1eb002ede157bd8ffcb04 -> main

@github-actions github-actions bot merged commit ea65cf1 into main Aug 8, 2024
6 checks passed
@github-actions github-actions bot deleted the fix-statistics-creation-for-seasonal-booking branch August 8, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants