Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] Add new app layout & relocate API to it #1340

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[1.1] Add new app layout & relocate API to it #1340

merged 2 commits into from
Oct 1, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Sep 18, 2024 •
edited
Loading

MUST BE MIGRATED FIRST, NOT AT THE SAME TIME AS OTHER MIGRATIONS!

🛠️ Changelog

  • Add new layout that will be used for the new app.
  • Move API to new app

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu added refactor Refactors something improvement Improves an existing feature labels Sep 18, 2024
@matti-lamppu matti-lamppu self-assigned this Sep 18, 2024
@matti-lamppu matti-lamppu removed the improvement Improves an existing feature label Sep 18, 2024
@matti-lamppu matti-lamppu changed the title Layout app structure Migrate the project to a single app Sep 18, 2024
@matti-lamppu matti-lamppu force-pushed the one-app branch 3 times, most recently from 2518581 to 50a8004 Compare September 18, 2024 07:13
@matti-lamppu matti-lamppu changed the title Migrate the project to a single app Add new app layout Sep 18, 2024
@matti-lamppu matti-lamppu changed the title Add new app layout Add new app layout & relocate API to it Sep 18, 2024
@matti-lamppu matti-lamppu force-pushed the one-app branch 2 times, most recently from 9d7df6d to e101dc3 Compare September 18, 2024 13:14
@matti-lamppu matti-lamppu marked this pull request as ready for review September 19, 2024 04:45
vergama
vergama approved these changes Sep 19, 2024
View reviewed changes
Copy link

@vergama vergama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was a lot of files.

@matti-lamppu matti-lamppu force-pushed the rename-project branch 2 times, most recently from d13b495 to 808c6d8 Compare September 27, 2024 04:43
@matti-lamppu matti-lamppu force-pushed the one-app branch 2 times, most recently from b80ca7f to 76d6d10 Compare September 27, 2024 06:16
@matti-lamppu matti-lamppu added the dependencies Updates a dependency label Sep 27, 2024
@matti-lamppu matti-lamppu changed the title Add new app layout & relocate API to it [MERGE FIRST] Add new app layout & relocate API to it Sep 27, 2024
@matti-lamppu matti-lamppu changed the title [MERGE FIRST] Add new app layout & relocate API to it [1.1] Add new app layout & relocate API to it Sep 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.2% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarCloud

@matti-lamppu matti-lamppu merged commit 28307a8 into rename-project Oct 1, 2024
6 checks passed
@matti-lamppu matti-lamppu deleted the one-app branch October 1, 2024 14:31
@matti-lamppu matti-lamppu mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranta ranta ranta approved these changes

@vergama vergama vergama approved these changes

Assignees

@matti-lamppu matti-lamppu

Labels
dependencies Updates a dependency refactor Refactors something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matti-lamppu @vergama @ranta