Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated features #1452

Merged
merged 12 commits into from
Nov 29, 2024
Merged

Remove deprecated features #1452

merged 12 commits into from
Nov 29, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Nov 27, 2024 •
edited
Loading

🛠️ Changelog

  • Removes some deprecated models:
    • Service Sector
    • Service
    • Real Estate
    • Building
    • Introduction
    • Keyword
    • Keyword Group
    • Keyword Category
  • Removes some deprecated fields on models
    • Resource buffer times
    • ReservationUnitCancellationRule needs handling boolean
  • Fixed one nullable CharField issue
  • Add ext_id UUID fields to reservations and recurring reservations for "keyless entry"
  • Make translation check check for removed translations as well & fix printing

🧪 Test plan

  • Automated tests

🚧 Dependencies

🎫 Tickets

@matti-lamppu matti-lamppu added refactor Refactors something breaking Requires frontend changes labels Nov 27, 2024
@matti-lamppu matti-lamppu self-assigned this Nov 27, 2024
@matti-lamppu matti-lamppu changed the title Remove deprecated models Remove deprecated features Nov 27, 2024
@matti-lamppu matti-lamppu force-pushed the remove-deprecated-models branch from ee972ce to 00ac2cb Compare November 28, 2024 07:59
@matti-lamppu matti-lamppu marked this pull request as ready for review November 28, 2024 08:46
@matti-lamppu matti-lamppu requested review from ranta and vergama and removed request for ranta November 28, 2024 08:46
@vergama
Copy link

vergama commented Nov 28, 2024

We need to give a heads up that the Res.Unit CSV export columns change when this goes to prod.

@joonatank joonatank mentioned this pull request Nov 28, 2024
Merged
@matti-lamppu matti-lamppu force-pushed the remove-deprecated-models branch 2 times, most recently from ecf625d to e2af9f0 Compare November 29, 2024 08:54
@matti-lamppu
Add UUID fields to reservation models for future "keyless entry"
9594185 
- Rename recurring reservation `uuid` -> `ext_uuid`
- Add `ext_uuid` field to reservation
- Add `reservation_uuid` field to statistics
- Add `ext_uuid` fields to graphql schema
@matti-lamppu matti-lamppu force-pushed the remove-deprecated-models branch from e2af9f0 to 9594185 Compare November 29, 2024 09:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
26.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

@matti-lamppu
Copy link
Collaborator Author

/ff

@github-actions github-actions bot merged commit 9594185 into main Nov 29, 2024
4 of 5 checks passed
@github-actions github-actions bot deleted the remove-deprecated-models branch November 29, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranta ranta ranta approved these changes

@vergama vergama vergama approved these changes

Assignees

@matti-lamppu matti-lamppu

Labels
breaking Requires frontend changes refactor Refactors something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matti-lamppu @vergama @ranta