Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seasonal Reservation Emails #1468

Merged
merged 22 commits into from
Dec 16, 2024
Merged

Seasonal Reservation Emails #1468

merged 22 commits into from
Dec 16, 2024

Conversation

ranta
Copy link
Collaborator

@ranta ranta commented Dec 12, 2024 •
edited by jira bot
Loading

🛠️ Changelog

  • Add a bunch of new emails when seasonal reservations/application sections/reservation series get modified/cancelled/rejected

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@ranta ranta force-pushed the email-cancel-seasonal branch from bda927b to 7192542 Compare December 12, 2024 18:05
@ranta ranta force-pushed the email-cancel-seasonal branch from 7192542 to 32ddc13 Compare December 13, 2024 14:39
matti-lamppu
matti-lamppu approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@matti-lamppu matti-lamppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only very minor comments from me, looks good otherwise.

ranta added 4 commits December 16, 2024 15:15
@ranta
Alphabetize email types, contexts and send methods
f6776fe 
- Enhance code, readability maintainability and developer viewing pleasure by incorporating structured visual delineation through section separators and streamlined formatting (add pretty dividers).
@ranta
Rename booking_number variable name to reservation_id in Emails
d8341e7 
- Removes a second name for the same value
@ranta
Refactor email sending tasks convert EmailData into a dataclass
a0cc59b
@ranta
Email: Simplify tester form initial data
b36cff4
ranta added 18 commits December 16, 2024 15:15
@ranta
Email: Simplify render tests with get_mock_data
ef50ba6
@ranta
Email: Add emails for SEASONAL_RESERVATION_REJECTED_SINGLE
aefbdac
@ranta
Email: Add emails for SEASONAL_RESERVATION_CANCELLED_SINGLE
84f7833
@ranta
Email: Add emails for SEASONAL_RESERVATION_MODIFIED_SINGLE
f9a7f2d
@ranta
Email: Add emails for SEASONAL_RESERVATION_MODIFIED_SERIES
d0aa60f
@ranta
Email: Add emails for SEASONAL_RESERVATION_REJECTED_SERIES
77f2c8e
@ranta
Email: Add emails for APPLICATION_SECTION_CANCELLED
08d2384
@ranta
Email: Add emails for STAFF_NOTIFICATION_APPLICATION_SECTION_CANCELLED
30f3e01
@ranta
Fix incorrect usages of super()
7dadc86
@ranta
Use only EmaiLData type argument in send_emails_in_batches_task
9141452
@ranta
Don't sent cancellation emails if Application status is not RESULTS_SENT
6e13122
@ranta
Simplify checking if application section exists for reservation series
66946e8
@ranta
Move cancelled_reservation_series value to form and get_mock_data
eaa21bf
@ranta
Fix incorrect text used in series rejected email
1e6de12
@ranta
Fix email typing issues
e7d49c9
@ranta
Fix sending section cancelled email to all reservation unit staff users
c74a4d9
@ranta
Get seasonal email recipients from application instead of reservation
9f88f8b
@ranta
Get seasonal email recipient name from application, not reservation
5fe85cd
@ranta ranta force-pushed the email-cancel-seasonal branch from 32ddc13 to 5fe85cd Compare December 16, 2024 13:38
@ranta ranta enabled auto-merge (rebase) December 16, 2024 13:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ranta ranta merged commit e2c9814 into main Dec 16, 2024
5 of 6 checks passed
@ranta ranta deleted the email-cancel-seasonal branch December 16, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergama vergama vergama left review comments

@matti-lamppu matti-lamppu matti-lamppu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranta @vergama @matti-lamppu