Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .test-durations to artifacts instead of creating pull requests #1517

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Feb 3, 2025

🛠️ Changelog

  • Store .test-durations file used to parallelize tests in GitHub Actions in GitHub artifacts instead of in the project repo, since updating it requires a PR, which cannot be automatically merged if created by GitHub actions bot (also, said PR would create massive diffs).

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

@matti-lamppu matti-lamppu added the improvement Improves an existing feature label Feb 3, 2025
@matti-lamppu matti-lamppu self-assigned this Feb 3, 2025
@matti-lamppu
Copy link
Collaborator Author

Seems like this PR cannot find the artifact I created by running the update-test-durations workflow manually. I think it has to do with the fact this change is not in main yet. Let's merge it without checks and I'll fix things if need be.

@matti-lamppu matti-lamppu marked this pull request as ready for review February 3, 2025 06:35
@matti-lamppu matti-lamppu requested a review from ranta February 3, 2025 06:35
@matti-lamppu matti-lamppu changed the title Add .test-durations to artifacts instead of creating pull requests Add .test-durations to artifacts instead of creating pull requests Feb 3, 2025
@matti-lamppu matti-lamppu force-pushed the artefact-test-durations branch from 21c63b4 to 04eb8a9 Compare February 4, 2025 12:25
@matti-lamppu matti-lamppu merged commit 36db541 into main Feb 4, 2025
5 of 17 checks passed
@matti-lamppu matti-lamppu deleted the artefact-test-durations branch February 4, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants