Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor backend for monorepo move #1527

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Refactor backend for monorepo move #1527

merged 1 commit into from
Feb 6, 2025

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Feb 5, 2025 •
edited
Loading

🛠️ Changelog

  • Facilitate moving project to a monorepo:
    • Move project to a directory named "backend"
    • Rename workflows to not conflict with frontend ones
    • Update .gitignore to merged version between backend and frontend
  • Update paths on various commands to support backend being in a subdirectory
  • Remove bandit and safety pre-commit hooks
  • Add new top-level README and move current one to the backend directory.
    • Add mention of how to setup source directory for lining etc.

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu self-assigned this Feb 5, 2025
@matti-lamppu matti-lamppu force-pushed the backend-changes-for-monorepo branch from 1163e3f to f998253 Compare February 5, 2025 10:04
@matti-lamppu matti-lamppu force-pushed the remove-require-introduction-field branch from 13813f5 to 2f1cc82 Compare February 5, 2025 10:13
@matti-lamppu matti-lamppu force-pushed the backend-changes-for-monorepo branch 4 times, most recently from 82aff9d to 3e924bb Compare February 5, 2025 10:51
@matti-lamppu matti-lamppu force-pushed the remove-require-introduction-field branch from 2f1cc82 to 62ceeae Compare February 5, 2025 11:21
@matti-lamppu matti-lamppu force-pushed the backend-changes-for-monorepo branch 4 times, most recently from c575c3f to 9f048b6 Compare February 5, 2025 12:19
Base automatically changed from remove-require-introduction-field to main February 5, 2025 12:23
@matti-lamppu matti-lamppu marked this pull request as ready for review February 5, 2025 12:31
@matti-lamppu matti-lamppu requested review from vergama and ranta February 5, 2025 12:31
@matti-lamppu matti-lamppu force-pushed the backend-changes-for-monorepo branch from 9f048b6 to 98bab56 Compare February 5, 2025 12:34
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
51 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.6% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

ranta
ranta approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@ranta ranta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@matti-lamppu
Copy link
Collaborator Author

/ff

@github-actions github-actions bot merged commit 98bab56 into main Feb 6, 2025
19 checks passed
@github-actions github-actions bot deleted the backend-changes-for-monorepo branch February 6, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranta ranta ranta approved these changes

@vergama vergama Awaiting requested review from vergama

Assignees

@matti-lamppu matti-lamppu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matti-lamppu @ranta