JSON Export API #1531
Open
JSON Export API #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranta
approved these changes
Feb 6, 2025
matti-lamppu
force-pushed
the
statistics-export-api
branch
2 times, most recently
from
f6bfb73 to
dc4d316
Compare
vergama
reviewed
Feb 7, 2025
| msg = "Not authorized to export reservation statistics." | ||
| return HttpResponseForbidden(msg) | ||
|
|
||
| queryset = ReservationStatistic.objects.all() |
There was a problem hiding this comment.
I guess some kind of filter is needed but that could be added later after agreeing what it should be. (The data can be updated until the reservations are in the past, so the client can't just naively query today's statistics but maybe doesn't want a full update every time either. But if there is no need not know about upcoming reservations until they have taken place, a chunk containing the recent past could be queried on a weekly or daily basis.)
There was a problem hiding this comment.
We should ask Milla to find out what kind of filter they would like, if any.
vergama
approved these changes
Feb 7, 2025
matti-lamppu
force-pushed
the
statistics-export-api
branch
from
dc4d316 to
ea142b0
Compare
matti-lamppu
force-pushed
the
statistics-export-api
branch
from
ea142b0 to
253aa7a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
🧪 Test plan
🚧 Dependencies
EXPORT_AUTHORIZATION_TOKENto Azure key vaults and sync to OpenShift.🎫 Tickets