New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenRecords v3.5 - Develop #559

Merged

zgary merged 61 commits into develop from main-merge

Jan 20, 2023

Contributor

johnyu95 commented Nov 23, 2022

No description provided.

johnyu95 and others added 30 commits

April 2, 2020 15:59


          Merge pull request #520 from CityOfNewYork/develop

949c846

OpenRecords v3.4.2


          Merge pull request #524 from CityOfNewYork/develop

7d0c499

OpenRecords v3.4.3


          Merge pull request #527 from CityOfNewYork/develop

247a8bc

OpenRecords v3.4.5


          Merge pull request #529 from CityOfNewYork/develop

799c35c

OpenRecords v3.4.6


          Merge pull request #532 from CityOfNewYork/develop

340f14c

OpenRecords v3.4.7


          Merge pull request #534 from CityOfNewYork/develop

300098e

OpenRecords v3.4.8


          Add New Denial - No Records Available reason

f81d510

Adds new denial reason for DOB

Denied - No Records Available

Your request under the Freedom of Information Law (FOIL) is being closed. Your request is being fulfilled in part and denied in part. The Department is releasing a copy of the records we located. All other requested records were not found.


          Merge pull request #536 from CityOfNewYork/joelbcastillo-new-denial-r…

…eason-dob

Add New Denial - No Records Available reason


          Added need_additional_details column to Reasons table

25e093a


          Updated reason text for Fulfilled in Part

b66b12f


          Merge pull request #541 from CityOfNewYork/johnyu95-main-additional-d…

1b7655a

…etails-reasons

Added need_additional_details column to Reasons table


          Added read only user functionality

4d67baa


          Updated is_read_only to not nullable

d0afaef


          Merge pull request #542 from CityOfNewYork/johnyu95-agency-read-only

77389a3

Read Only Agency User


          Fixed bug with anonymous user read only check and private file access

ab75a1f


          Merge pull request #543 from CityOfNewYork/johnyu95-agency-read-only

96797ab

Agency Read Only Bug Fixes


          Added dataset fields for note responses WIP

9858b52


          Fixed injection vulnerability in new request page

9ffd98d


          Merge pull request #545 from CityOfNewYork/johnyu95-new-request-vulne…

db6d6b4

…rability-fix

Fixed injection vulnerability in new request page


          Fix XSS issue on response row and modal

d1aa368


          Updated response row and modal ID format

9199b5e


          Fix quotes for jinja in javascript

fa3f601


          Merge pull request #546 from CityOfNewYork/g-zhou-xss-response-fix

1c798cf

Fix XSS Vulnerability on Responses Row and Modal


          Revert "Merge pull request #546 from CityOfNewYork/g-zhou-xss-respons…

70695af

…e-fix"

This reverts commit 1c798cf, reversing
changes made to db6d6b4.


          Add fix for XSS on add note

995ce20


          Updated character limits for escaped values and cleaned up XSS fix

d361a1e


          Use tojson instead of safe in response row and notes

59cc291


          Add delete_doc function

bdb17ff


          Merge pull request #547 from CityOfNewYork/xss-add-note-fix

4b4cf55

Fix XSS on Add Note


          Fixed escaped values not displaying properly in confirmation email te…

884e7b2

…mplates

johnyu95 and others added 17 commits

February 28, 2022 15:20


          Finished dataset option for notes

412a017


          Added dataset checkbox for files, links, and instructions

0f3515d


          Removed unused code

4fe067a


          Updated dataset description limits and fixed edit note functionality

aa3dfb1


          Add comments to document set_edited_data method

f3a7366


          Merge pull request #550 from CityOfNewYork/johnyu95-response-dataset

6b1821b

OpenData Dataset Checkbox for Responses


          Removed dataset fields from Notes and Instructions

11e49e7


          Merge pull request #551 from CityOfNewYork/johnyu95-dataset-changes

0aef096

Removed dataset fields from Notes and Instructions


          Updated language on request page for no responses

3be294d


          Merge pull request #554 from CityOfNewYork/johnyu95-no-responses-lang…

faa2fad

…uage

Update No Responses Language


          Updated Open Data compliance report

e68cecb


          Standardized variable names in Open Data compliance report function

4cad0a8


          Fixed link data sets query

d8715c5


          Merge pull request #555 from CityOfNewYork/johnyu95-open-data-complia…

66a905e

…nce-report

Updated Open Data Compliance Report


          Merged with develop

7b3d6d1


          Merged with develop and updated dependencies

81cc7f4


          Updated send_file parameter name

f8271a1

johnyu95 requested a review from zgary

November 23, 2022 16:01

johnyu95 assigned zgary

accesslint bot reviewed

View reviewed changes

accesslint bot left a comment

There are accessibility issues in these changes.

app/templates/request/_edit_requester_info.html

                                   {{ edit_requester_form.title.label }}
-                                  {{ edit_requester_form.title(id='inputTitle', class='form-control', maxlength="64",
-                                      readonly=is_public_requester) }}
+                                  <input name="title" id="inputTitle" class="form-control" maxlength="64" {% if is_requester_information_readonly %}readonly{% endif %} {% if request.requester.title %}value="{{ request.requester.title | safe }}"{% endif %}>

accesslint bot Nov 23, 2022

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

app/templates/request/_edit_requester_info.html

                                   <p id="user-title-character-count" class="character-counter">64 characters remaining</p>
                                   {{ edit_requester_form.organization.label }}
-                                  {{ edit_requester_form.organization(id='inputOrganization', class='form-control', maxlength="128",
-                                      readonly=is_public_requester) }}
+                                  <input name="organization" id="inputOrganization" class="form-control" maxlength="128" {% if is_requester_information_readonly %}readonly{% endif %} {% if request.requester.organization %}value="{{ request.requester.organization | safe }}"{% endif %}>

accesslint bot Nov 23, 2022

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

app/templates/request/_edit_requester_info.html

                                   {{ edit_requester_form.address_one.label }}
-                                  {{ edit_requester_form.address_one(id='inputAddressOne', class='form-control',
-                                      readonly=is_public_requester) }}
+                                  <input name="address_one" id="inputAddressOne" class="form-control" {% if is_requester_information_readonly %}readonly{% endif %} {% if request.requester.mailing_address.get("address_one") is not none %}value="{{ request.requester.mailing_address.get("address_one") | safe }}"{% endif %}>

accesslint bot Nov 23, 2022

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

app/templates/request/_edit_requester_info.html

                                   {{ edit_requester_form.address_two.label }}
-                                  {{ edit_requester_form.address_two(id='inputAddressTwo', class='form-control',
-                                      readonly=is_public_requester) }}
+                                  <input name="address_two" id="inputAddressTwo" class="form-control" {% if is_requester_information_readonly %}readonly{% endif %} {% if request.requester.mailing_address.get("address_two") is not none %}value="{{ request.requester.mailing_address.get("address_two") | safe }}"{% endif %}>

accesslint bot Nov 23, 2022

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

app/templates/request/_edit_requester_info.html

    
                                  {{ edit_requester_form.city.label }}

                                  {{ edit_requester_form.city(id='inputCity', class='form-control', readonly=is_public_requester) }}

                                  <input name="city" id="inputCity" class="form-control" {% if is_requester_information_readonly %}readonly{% endif %} {% if request.requester.mailing_address.get("city") is not none %}value="{{ request.requester.mailing_address.get("city") | safe }}"{% endif %}>

accesslint bot Nov 23, 2022

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

lgtm-com bot commented Nov 23, 2022

This pull request introduces 10 alerts when merging f8271a1 into 800a9cd - view on LGTM.com

new alerts:

6 for Unused import
2 for Wrong name for an argument in a call
1 for Unused local variable
1 for Potentially unsafe external link

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.


          Added agency name and acronym to es_update

f54420a

lgtm-com bot commented Nov 30, 2022

This pull request introduces 10 alerts when merging f54420a into 800a9cd - view on LGTM.com

new alerts:

6 for Unused import
2 for Wrong name for an argument in a call
1 for Unused local variable
1 for Potentially unsafe external link

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

zgary requested changes

View reviewed changes

Contributor

zgary left a comment

Minor changes requested.

app/request/views.py Outdated Show resolved Hide resolved

app/request/views.py Outdated Show resolved Hide resolved

app/response/views.py Outdated Show resolved Hide resolved


          Removed unused code and added custom form name fix

26b6cb4

johnyu95 mentioned this pull request

Fixed form name in custom request forms json #556

Closed

johnyu95 and others added 2 commits

December 21, 2022 10:33


          Added option to toggle MFA

040f1ee


          Add minor code review changes

99169d7

zgary approved these changes

View reviewed changes

Contributor

zgary left a comment

Looks good 👍

zgary merged commit b8f97df into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet