This repository was archived by the owner on Mar 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Update neo-boa to integrate with CityOfZion/neo-python#716 #111
Open
jseagrave21
wants to merge
6
commits into
CityOfZion:development
Choose a base branch
from
jseagrave21:patch-1
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update for new fixtures
jseagrave21
commented
Nov 20, 2018
FIXTURE_FILENAME = 'fixtures/empty_fixture.tar.gz' | ||
|
||
wallet_1_script_hash = UInt160(data=b'S\xefB\xc8\xdf!^\xbeZ|z\xe8\x01\xcb\xc3\xac/\xacI)') | ||
|
||
wallet_1_addr = 'APRgMZHZubii29UXF9uFa6sohrsYupNAvx' | ||
wallet_1_addr = 'AJQ6FoaSXDFzA6wLnyZ1nFN7SGSN2oNTc3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the wallet address here because the previous wallet address does not correspond to neo-test1-w.wallet whereas wallet_1_addr
does correspond correctly here
neo-boa/boa_test/tests/boa_test.py
Line 56 in dd8b235
wallet_1_addr = 'AJQ6FoaSXDFzA6wLnyZ1nFN7SGSN2oNTc3' |
- update wallet_1_script_hash
- update wallet fixture files
- for 'get_time'
- update the correct from-addr
@localhuman please see CityOfZion/neo-python#716 for proof of functionality (the PR is pulling from this branch right now) |
Merge CoZ development into jseagrave21 patch-1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixtures_v9.tar.gz
parse_and_sign
neo-python#716How did you solve this problem?
trial and error