Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Fix getcontractstate to match neo-cli #750

Merged
merged 30 commits into from
Dec 12, 2018
Merged

Fix getcontractstate to match neo-cli #750

merged 30 commits into from
Dec 12, 2018

Conversation

jseagrave21
Copy link
Contributor

What current issue(s) does this address, or what feature is it adding?

How did you solve this problem?
Trial and Error

How did you make sure your solution works?
Manual Testing and Unittest

Are there any special changes in the code that we should be aware of?
No

Please check the following, if applicable:

  • Did you add any tests? (I updated tests)
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

jseagrave21 and others added 30 commits October 9, 2018 20:38
@jseagrave21
Merge pull request #38 from CityOfZion/development
13e979b 
Merge CoZ Development into jseagrave21 Development
@jseagrave21
Merge pull request #40 from CityOfZion/development
e41e950 
Merge CoZ Development into jseagrave21 Development
@jseagrave21
Merge pull request #41 from CityOfZion/development
7db54f4 
Merge CoZ Development into jseagrave21 Development
@jseagrave21
Fix ExtendedJsonRpcApi (CityOfZion#662)
54a4f3f 
* Update ExtendedJsonRpcApi.py

- add fix provided by @localhuman so original methods are returned as well as extended methods
@ixje @jseagrave21
Mute expected test stacktrace and clearly identify why an exception i…
0f96dc3 
…s thrown. (CityOfZion#663)
@dauTT @jseagrave21
Add guideline for adding tests to the neo-privnet-unittest image (Cit…
1e5b4dc 
…yOfZion#661)

* Add the option -u (unittest-net) to prompt.py

* Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package
@jseagrave21
Update CHANGELOG.rst
8febcf1 
for compatibility
@jseagrave21
Update CHANGELOG.rst
c7a790f
@jseagrave21
Merge CoZ Development into jseagrave21 Development (#49)
c51390e 
* Fix ExtendedJsonRpcApi (CityOfZion#662)

* Update ExtendedJsonRpcApi.py

- add fix provided by @localhuman so original methods are returned as well as extended methods

* Mute expected test stacktrace and clearly identify why an exception is thrown. (CityOfZion#663)

* Add guideline for adding tests to the neo-privnet-unittest image (CityOfZion#661)

* Add the option -u (unittest-net) to prompt.py

* Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package

* Add raw transaction building examples (CityOfZion#665)

* Update neo-boa version to fix core building test
@jseagrave21
Merge pull request #50 from CityOfZion/development
32a16e3 
Merge CoZ Development into jseagrave21 Development
@jseagrave21
Merge pull request #53 from CityOfZion/development
3c8232d 
Merge CoZ Development into jseagrave21 Development
@jseagrave21
Merge pull request #54 from CityOfZion/development
1b00db8 
Merge CoZ Development into jseagrave21 Development
@jseagrave21
Merge pull request #58 from CityOfZion/development
eb495bf 
Merge CoZ Development into jseagrave21 development
@jseagrave21
Merge pull request #63 from CityOfZion/development
4df642e 
Merge CoZ development into jseagrave21 development
@jseagrave21
Update test_extended_json_rpc_api.py
e12e746 
- add tests for "showallaccounts" and "showallaccountstates"
@jseagrave21
Update test_extended_json_rpc_api.py
0f55903 
- revert
@jseagrave21
Merge pull request #64 from CityOfZion/development
7eb4a1e 
Merge neo-python development into jseagrave21 development
@jseagrave21
Merge pull request #66 from CityOfZion/development
1f40685 
Merge neo-python development into jseagrave21 development
@jseagrave21
Merge pull request #74 from CityOfZion/development
16f5163 
Merge neo-python development into jseagrave21 development
@jseagrave21
Merge pull request #81 from CityOfZion/development
ff49beb 
Merge CoZ development into jseagrave21 development
@jseagrave21
Merge pull request #82 from CityOfZion/development
05ce2e7 
Gracefully handle NEP-5 balance query failures (CityOfZion#744)
@jseagrave21
Update ContractState.py
6877a3b 
- update for parody with neo-cli 2.9.2
@jseagrave21
Update FunctionCode.py
fc829cf 
- update for parody with neo-cli 2.9.2
@jseagrave21
Update ContractParameterType.py
dcf7935 
- fix so ToName works
@jseagrave21
Update test_transactions.py
68f667c 
- update so test passes
@jseagrave21
Update test_json_rpc_api.py
cd4968c 
- update so test passes
@jseagrave21
Update SmartContractEvent.py
b89a456 
- update for integration with previous changes and so tests pass
@jseagrave21
Update CHANGELOG.rst
fa749dc
@jseagrave21
Update ContractState.py
a2e6cc6 
- consolidate code
@jseagrave21
Update test_json_rpc_api.py
57ebadd 
- fix test
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 83.969% when pulling 57ebadd on jseagrave21:fix-getcontractstate into f076936 on CityOfZion:development.

@jseagrave21 jseagrave21 mentioned this pull request Dec 12, 2018
Merged
5 tasks
@ixje
Copy link
Member

ixje commented Dec 12, 2018

Thanks for the quick fix! 🥇

@ixje ixje merged commit 633095f into CityOfZion:development Dec 12, 2018
@jseagrave21 jseagrave21 deleted the fix-getcontractstate branch December 12, 2018 15:17
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Dec 12, 2018
@jseagrave21
Update Show.py
10dc2b1 
- update for CityOfZion#750
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Dec 12, 2018
@jseagrave21
Update FunctionCode.py
7fcd600 
- update for CityOfZion#750
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Dec 12, 2018
@jseagrave21
Update ContractState.py
4fbebf9 
- update for CityOfZion#750
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Dec 12, 2018
@jseagrave21
Update test_transactions.py
1f8ab44 
- update for CityOfZion#750
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Dec 12, 2018
@jseagrave21
Update ContractParameterType.py
7cbdb94 
- update for CityOfZion#750
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Dec 12, 2018
@jseagrave21
Update SmartContractEvent.py
03c4c0a 
- update for CityOfZion#750
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Dec 12, 2018
@jseagrave21
Update test_json_rpc_api.py
594074c 
- update for CityOfZion#750
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jseagrave21 @coveralls @ixje @dauTT