Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Fix JSON output of invocation transaction #751

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Fix JSON output of invocation transaction #751

merged 2 commits into from
Dec 12, 2018

Conversation

ixje
Copy link
Member

@ixje ixje commented Dec 12, 2018

What current issue(s) does this address, or what feature is it adding?
Fix #749

How did you solve this problem?
Fix return value of systemfee, change JSON print format of GAS key.
Note that fixing the system_fee results in fixing the net_fee, because
network_fee = input - output - SystemFee

How did you make sure your solution works?
make test and manually query tx to match output with neo-cli output shown in the issue.

Are there any special changes in the code that we should be aware of?
no

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

coveralls commented Dec 12, 2018

Coverage Status

Coverage remained the same at 83.969% when pulling 5744bfe on ixje:fix_getrawtx_output into 633095f on CityOfZion:development.

@ixje ixje merged commit ccf5bdd into CityOfZion:development Dec 12, 2018
@ixje ixje deleted the fix_getrawtx_output branch December 12, 2018 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants