This repository was archived by the owner on Nov 15, 2021. It is now read-only.
[refactor-prompt] update docs #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseagrave21
suggested changes
Jan 5, 2019
|
|
||
| neo> import multisig_addr 037b8992e8384212f82e05c8836816c0f14dff9528397138731638b17d6357021e 1 037b8992e8384212f82e05c8836816c0f14dff9528397138731638b17d6357021e 02883118351f8f47107c83ab634dc7e4 | ||
| neo> wallet import multisig_addr 037b8992e8384212f82e05c8836816c0f14dff9528397138731638b17d6357021e 1 02883118351f8f47107c83ab634dc7e4 |
There was a problem hiding this comment.
I am pretty sure you still need to include the your own pub key so that it is a signing key. This is how I imported the multisig_addr for #716
Also, you can check the tests I wrote here:
https://github.com/CityOfZion/neo-python/pull/716/files#diff-05df9a4abfee51be00e07ea6f20511a3R119
There was a problem hiding this comment.
#716 was before I changed it in #767
I thought it made no sense that we had to enter our own key twice, so I changed it. Note how I here add our own public key (from our wallet) to the signing_keys before feeding it to CreateMultiSigContract call.
https://github.com/ixje/neo-python/blob/4906feb6c661a613f65c4bafd0a0df1388d3f23e/neo/Prompt/Commands/Wallet.py#L552-L564
There was a problem hiding this comment.
That makes a lot more sense!
|
All good points. I scanned mostly for commands and their arguments that needed updating, but your review nicely caught a couple of improvements in the descriptions as well 👍 |
jseagrave21
approved these changes
Jan 5, 2019
There was a problem hiding this comment.
Great work! I would still like to use #716, especially for the lessons learned for changing the test fixtures. Also I was planning on using the tests for coverage for wallet sign (as I mentioned previously) any thoughts on how to get it merged or what changes I need to make? We can discuss separately if that is easier, just thought about it here.
|
we need the neo-boa update first, and that's out of my control |
jseagrave21
pushed a commit
to jseagrave21/neo-python
that referenced
this pull request
Jan 7, 2019
* update global readme * update docs * process feedback * update show contract output
ixje
added a commit
that referenced
this pull request
Jan 8, 2019
…ython into refactor-prompt * 'refactor-prompt' of https://github.com/CityOfZion/neo-python: (37 commits) fix calculation of change value when using alternating asset inputs (#803) [refactor-prompt] Fix #800 (#802) [refactor-prompt] Improve send & sendmany (third try) (#799) Fix send/sendmany default wallet source address for tx (#796) fix prompt printer for lists and other possible objects (#795) clarify insufficient funds error message due to not enough unspent outputs (#793) improve wallet usage help (#794) [refactor-prompt] restore theming support (#788) [refactor-prompt] update docs (#789) [refactor-prompt] enforce pw prompt send (#791) fix exception in help if command has no params (#792) add wallet password checking before exporting (#790) streamline parameter descriptions (#787) [refactor-prompt] add sc invoke (#786) [refactor-prompt] add sc deploy (#785) [refactor-prompt] add debugstorage command (#784) [refactor-prompt] cleanup 2 (#783) [refactor-prompt] add support for the sc group including build, build_run, and load_run (#779) split prompt wallet into multiple files (#782) Add wallet import contract_addr (#777) ...
ixje
added a commit
that referenced
this pull request
Jan 10, 2019
* Add the bases for making prompt commands plugin based (#720) * WIP make prompt commands plugin based Signed-off-by: Guillaume George <lysandergc@gmail.com> * Merge ixje:refactor-prompt Signed-off-by: Guillaume George <lysandergc@gmail.com> * Handle help detection in prompt.py Signed-off-by: Guillaume George <lysandergc@gmail.com> * Use CommandBase for subcommands to be able to have N levels of commands. Signed-off-by: Guillaume George <lysandergc@gmail.com> * Move "create wallet" command into "wallet" Signed-off-by: Guillaume George <lysandergc@gmail.com> * Improve CommandBase.register_sub_command to use the subcommand's CommandDesc.command as an id. (#725) Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix 1 word commands (#727) * Improve CommandBase.register_sub_command to use the subcommand's CommandDesc.command as an id. Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix exception when a command was used without arguments (for example "wallet") Signed-off-by: Guillaume George <lysandergc@gmail.com> * Add support for `wallet` `send`, `sendmany`, `sign`, `open`, and `close` (#726) * Prompt cleanup (#730) * Update description and clarify debug logs * Make return's explicit, clarify multi-sig help message * cleanup prompt * remove colour from initial help, sort commands alphabetically, cleanup descriptions * fix linting * process feedback * [refactor-prompt] Prompt fixes (#732) * Improve CommandBase.register_sub_command to use the subcommand's CommandDesc.command as an id. Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix CommandWalletCreateAddress missing parameter desc Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix missing words for autocompletion Signed-off-by: Guillaume George <lysandergc@gmail.com> * [refactor-prompt] Add missing tests for wallet create, verbose and create_addr (#733) * Add missing tests for wallet create, verbose and create_addr Signed-off-by: Guillaume George <lysandergc@gmail.com> * fix reviews Signed-off-by: Guillaume George <lysandergc@gmail.com> * [refactor prompt] Add support for search method group (#739) * [refactor prompt] Add support for show method group (pt 1) (#738) * Fix NodeLeader was not reset between test cases. (#742) This would lead to some problems when the blockchain is reset but the NodeLeader instance members are not. Transactions were still considered as known. Some members were not reset in NodeLeader.Setup() Also removed unsued member NodeLeader.MissionsGlobal Signed-off-by: Guillaume George <lysandergc@gmail.com> * Migrate command: wallet rebuild (#747) Signed-off-by: Guillaume George <lysandergc@gmail.com> * remove deprecated migrate command * remove deprecated migrate command (#748) * [refactor prompt] Add support for show method group (pt 2) (#741) * [refactor-prompt] Implement CommandWalletClaimGas (#740) * [refactor-prompt] Add wallet token base + delete (#757) * [refactor-prompt] Migrate command: wallet delete_addr (#752) * Migrate command: wallet delete_addr Signed-off-by: Guillaume George <lysandergc@gmail.com> * UserWallet.DeleteAddress now returns False on error + proper handling of invalid addresses in CommandWalletDeleteAddress Signed-off-by: Guillaume George <lysandergc@gmail.com> * Migrate command: wallet alias (#753) Signed-off-by: Guillaume George <lysandergc@gmail.com> * [refactor-prompt] Add wallet token send (#758) * remove deprecated migrate command * Add wallet token send * Update requirements and use isValidPublicAddress from new neo-python-core version * - fix send token description - process feedback * fix doc string typo * [refactor prompt] Add support for config group pt1 (#759) * add wallet import nep2/wif (#765) * [refactor-prompt] add wallet token history (#763) * Add wallet token history * process feedback * fix broken test after base branch merge * [refactor-prompt] add wallet export commands (#764) * add wallet export commands * Fix export nep2 to ask for passwords to prevent pw leaking to logs * process feedback * [refactor-prompt] add wallet import watchaddr (#766) * [refactor-prompt] add token sendfrom (#761) * [refactor-prompt] add import multisig_addr (#767) * add import multsig address * remove obsolete function * [refactor-prompt] Migrate command: wallet unspent (#760) * migrate command: wallet unspent Signed-off-by: Guillaume George <lysandergc@gmail.com> * wallet unspent - add tests Signed-off-by: Guillaume George <lysandergc@gmail.com> * fix arguments names and missing doc Signed-off-by: Guillaume George <lysandergc@gmail.com> * Handle review: add feedback when there is no asset matching the arguments + use neocore.Utils.isValidPublicAddress Signed-off-by: Guillaume George <lysandergc@gmail.com> * [refactor prompt] Add support for config maxpeers (#762) * add token approve and token allowance (#769) * add config nep8 (#771) * [refactor-prompt] Migrate command: wallet split (#770) * Migrate command wallet split Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix some comments Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix command desc + remove print() calls committed by mistake Signed-off-by: Guillaume George <lysandergc@gmail.com> * Add tests for CommandWalletSplit Signed-off-by: Guillaume George <lysandergc@gmail.com> * Review: test_wallet_split use string arguments instead of ints Signed-off-by: Guillaume George <lysandergc@gmail.com> * Handle Reviews - handle negative fees, improve error messages Signed-off-by: Guillaume George <lysandergc@gmail.com> * add token mint (#773) * [refactor prompt] Fix `search asset` and `search contract` (#774) * Update prompt.py - add CommandShow and CommandSearch to prompt * Update prompt.py revert changes * Update Search.py - update `search contract` and `search asset` per #623 (comment) * Update test_search_commands.py - add tests in case no search parameter is provided * add token register (#775) * [refactor-prompt] Migrate command: wallet import token (#772) * test_wallet_commands.py: Move tests of non commands at the end Signed-off-by: Guillaume George <lysandergc@gmail.com> * Add wallet import token Signed-off-by: Guillaume George <lysandergc@gmail.com> * Review: return None implicitly where possible Signed-off-by: Guillaume George <lysandergc@gmail.com> * Add a few tests for SplitUnspentCoin() Signed-off-by: Guillaume George <lysandergc@gmail.com> * CommandWalletImportToken - Handle review: better validation of contract_hash Signed-off-by: Guillaume George <lysandergc@gmail.com> * Add wallet import contract_addr (#777) Signed-off-by: Guillaume George <lysandergc@gmail.com> * split prompt wallet into multiple files (#782) * [refactor-prompt] add support for the sc group including build, build_run, and load_run (#779) * [refactor-prompt] cleanup 2 (#783) * make base command response consistent * fix plurality * check input parameters before closing wallet * streamline missing arguments response streamline accepted boolean options for config * process feedback * [refactor-prompt] add debugstorage command (#784) * add debugstorage command (and fix auto save linting error) * correct comments * [refactor-prompt] add sc deploy (#785) * add sc deploy (previously known as; import contract) * process feedback * [refactor-prompt] add sc invoke (#786) * add sc invoke (previously known as testinvoke) * process feedback * streamline parameter descriptions (#787) * add wallet password checking before exporting (#790) * fix exception in help if command has no params (#792) * [refactor-prompt] enforce pw prompt send (#791) * remove password bypass * remove unused import * [refactor-prompt] update docs (#789) * update global readme * update docs * process feedback * update show contract output * [refactor-prompt] restore theming support (#788) * re-store theming support * fix comment * improve wallet usage help (#794) * clarify insufficient funds error message due to not enough unspent outputs (#793) * fix prompt printer for lists and other possible objects (#795) * Fix send/sendmany default wallet source address for tx (#796) * [refactor-prompt] Improve send & sendmany (third try) (#799) * Update Send.py * Update test_send_command.py * rename test_send_command.py as test_send_commands.py * [refactor-prompt] Fix #800 (#802) * Update prompt.py - add CommandShow and CommandSearch to prompt * Update prompt.py revert changes * Fix #800 - adds support for contracts not requiring params * fix calculation of change value when using alternating asset inputs (#803) * test print fix * oops * test again * update makefile * update changelog to trigger stuck build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
#623 changes a lot of cli commands and some output. This PR updates the
readthedocsdocumentation.How did you solve this problem?
update commands
How did you make sure your solution works?
make docs& browse a littleAre there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)