This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wallet._current_height seems to always be one higher than the db/blockchain heights. Does this track? Should I modify the height to subtract 1 for display purposes to avoid confusion? |
I actually encountered this issue yesterday as well in my neo-python/neo/Wallets/Wallet.py Lines 653 to 662 in fe90f62
to this while self._current_height < Blockchain.Default().Height and (block_limit == 0 or blockcount < block_limit):
block = Blockchain.Default().GetBlockByHeight(self._current_height)
if block is not None:
self.ProcessNewBlock(block)
else:
break
blockcount += 1 and a single wallet rebuild will be enough at least that way we avoid confusion when looking at the toolbar code |
ixje
suggested changes
Mar 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
Ok, made the requested change |
ixje
approved these changes
Mar 14, 2019
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
Monitoring wallet height requires getting all the wallet info which can be slow depending on how many address/tokens/contracts exist in the wallet
How did you solve this problem?
Added the current wallet height to the bottom toolbar in the same format neo-cli uses (wallet height/db height/blockchain height)
How did you make sure your solution works?
Manual testing
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)