Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Add PICKITEM for ByteArray into VM #923

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Add PICKITEM for ByteArray into VM #923

merged 3 commits into from
Mar 29, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Mar 28, 2019

What current issue(s) does this address, or what feature is it adding?
neo-project/neo-vm#98

How did you solve this problem?
write code

How did you make sure your solution works?
run VM test vectors

Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@ixje
Copy link
Member Author

ixje commented Mar 29, 2019

StackItem.New did not create a ByteArray when receiving a str input value therefore failing some local tests. The VM test-vectors did not cover this.
C# ref: https://github.com/neo-project/neo-vm/blob/bfb68c806f52ed773ae7badff3b652e96e257c61/src/neo-vm/StackItem.cs#L95-L98

@coveralls
Copy link

coveralls commented Mar 29, 2019

Coverage Status

Coverage decreased (-0.01%) to 86.764% when pulling 217c6e5 on ixje:pickitem-vm into bcb46c4 on CityOfZion:development.

@ixje ixje merged commit 0a2b8b0 into CityOfZion:development Mar 29, 2019
@ixje ixje deleted the pickitem-vm branch March 29, 2019 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants