Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and update dependencies #851

Closed
brylie opened this issue Apr 20, 2021 · 22 comments
Closed

Clean up and update dependencies #851

brylie opened this issue Apr 20, 2021 · 22 comments
Assignees
Labels
good first issue help wanted mentoring Issues that need active mentoring.
Milestone

Comments

@brylie
Copy link
Member

brylie commented Apr 20, 2021

Make sure all dependencies are up to date (in addition to Django 3.2 LTS #848). Also, remove unneeded dependencies, such as

  • django-notifications-hq (double-check how it is being used)
  • channels
  • asgi-redis
  • coreapi
  • requests (after disabling code that integrates 3rd party Propublica data)
  • sunlight
  • honcho
  • sentry-sdk
@North15
Copy link
Contributor

North15 commented May 17, 2021

Hey @brylie, I would like to take on this task if it's still open and needs to be resolved. Thanks.

@soumallyadev07
Copy link

Hey @brylie Would love to help with this!

@brylie
Copy link
Member Author

brylie commented May 18, 2021

Thanks, @soumallyadev07! Please let me know your progress and any hurdles in getting a development environment set up. I'll assign you to the issue, so we can indicate that it is in progress.

@brylie
Copy link
Member Author

brylie commented May 18, 2021

@soumallyadev07, would you mind saying how you found out about the CiviWiki project? I want to continue with community-building efforts, so any information about how to reach new contributors is welcome.

@brylie
Copy link
Member Author

brylie commented May 18, 2021

@soumallyadev07 would you be willing to start by upgrading the Django dependency to version 3.2 LTS? If so, we can start with issue #848

@soumallyadev07
Copy link

Thanks, @soumallyadev07! Please let me know your progress and any hurdles in getting a development environment set up. I'll assign you to the issue, so we can indicate that it is in progress.

I'll set up my Dev Environment and get started!

@soumallyadev07
Copy link

@soumallyadev07, would you mind saying how you found out about the CiviWiki project? I want to continue with community-building efforts, so any information about how to reach new contributors is welcome.

I actually found this project on https://up-for-grabs.net/

@soumallyadev07
Copy link

@soumallyadev07 would you be willing to start by upgrading the Django dependency to version 3.2 LTS? If so, we can start with issue #848

Sure! I'll upgrade and send a pull request for you to check

@soumallyadev07
Copy link

@soumallyadev07 would you be willing to start by upgrading the Django dependency to version 3.2 LTS? If so, we can start with issue #848

Hey! I'm trying to set up my Dev Environment and upgrading the dependencies and I ran into 2 issues as of now, the psycopg2 is not getting install and throwing an error(Attached Screenshot).
error

2nd issue is coming from asgi-redis as it requires a lower version of channels while Django and some other libraries demand a higher one and there is no common version.

@mohas1203
Copy link

mohas1203 commented May 18, 2021

@soumallyadev07 would you be willing to start by upgrading the Django dependency to version 3.2 LTS? If so, we can start with issue #848

Hey! I'm trying to set up my Dev Environment and upgrading the dependencies and I ran into 2 issues as of now, the psycopg2 is not getting install and throwing an error(Attached Screenshot).
error

2nd issue is coming from asgi-redis as it requires a lower version of channels while Django and some other libraries demand a higher one and there is no common version.

Instead of trying pip install psycopg2 try pip install psycopg2-binary, I'm pretty sure its the same thing. Check out this article to learn about the differences.

@soumallyadev07
Copy link

@soumallyadev07 would you be willing to start by upgrading the Django dependency to version 3.2 LTS? If so, we can start with issue #848

Hey! I'm trying to set up my Dev Environment and upgrading the dependencies and I ran into 2 issues as of now, the psycopg2 is not getting install and throwing an error(Attached Screenshot).
error
2nd issue is coming from asgi-redis as it requires a lower version of channels while Django and some other libraries demand a higher one and there is no common version.

Instead of trying pip install psycopg2 try pip install psycopg2-binary, I'm pretty sure its the same thing. Check out this article to learn about the differences.

Thanks! I installed psycopg2-binary but I still don't seem to understand the error that is being generated here.

@mohas1203
Copy link

@soumallyadev07 To install psycopg2 there are a lot of dependencies that you need for it whereas psycopg2-binary usually just works after being downloaded. You can also check out this discussion where the address some of the problems

@fardeenes7
Copy link
Contributor

Can I get a chance to work on the issue? I would really love to

soumallyadev07 pushed a commit to soumallyadev07/OpenCiviWiki that referenced this issue May 20, 2021
@brylie
Copy link
Member Author

brylie commented May 20, 2021

In reqrirements.txt, change the following line

psycopg2==2.8.6

to

psycopg2-binary==2.8.6

Then re-run the build process.

@brylie brylie added the mentoring Issues that need active mentoring. label May 20, 2021
@soumallyadev07
Copy link

In reqrirements.txt, change the following line

psycopg2==2.8.6

to

psycopg2-binary==2.8.6

Then re-run the build process.

I've changed and installed all the requirements and then tried to run -

python manage.py runserver

in the "project" folder but I'm getting the ModuleNotFoundError: No module named 'celery' error even though celery is installed using pip.
Screenshot (424)

@brylie
Copy link
Member Author

brylie commented May 21, 2021

Edit: we will keep the Celery dependency, as it is needed for sending emails.

@brylie
Copy link
Member Author

brylie commented May 21, 2021

Please notice the following part of the issue description:

Also, remove unneeded dependencies, such as

django-notifications-hq (double-check how it is being used)
channels
celery
asgi-redis
coreapi
requests (after disabling code that integrates 3rd party data)
sunlight
honcho
sentry-sdk

@fardeenes7
Copy link
Contributor

hey @brylie should I give it a try?

@brylie
Copy link
Member Author

brylie commented May 21, 2021

@fardeenes7 it is a bit confusing for multiple people to work on the same issue. Would you consider trying an issue that is not assigned in our 2.0 backlog?

https://github.com/CiviWiki/OpenCiviWiki/milestone/5

@brylie
Copy link
Member Author

brylie commented May 26, 2021

@North15 would you be interested in working on issue #848? That is a really important issue for keeping us up to date with Django LTS.

@North15
Copy link
Contributor

North15 commented May 26, 2021

@brylie Yes, I can start working on this issue.

@brylie
Copy link
Member Author

brylie commented May 26, 2021

@North15 ok, let's carry the conversation over to issue #848

@brylie brylie closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted mentoring Issues that need active mentoring.
Projects
None yet
Development

No branches or pull requests

5 participants