Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Django to 3.2.4 #910

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Upgraded Django to 3.2.4 #910

merged 4 commits into from
Jun 14, 2021

Conversation

North15
Copy link
Contributor

@North15 North15 commented Jun 7, 2021

This is in reference to issue #848.

Please let me know if any other changes are needed.

@pep8speaks
Copy link

pep8speaks commented Jun 7, 2021

Hello @North15! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-07 20:47:48 UTC

@a7madnassar
Copy link
Contributor

@North15 , I think these changes will break the upgrade. For example 'available_attrs' does not exist in django.utils.decorators in Django 3.2.4, so this will break the install, and that's why it was removed in the first place. Do you know why it is needed and what it breaks exactly? I was able to run the app fine with the previous changes. Also, why did you remove 'DFAULT_AUTO_FIELD' from settings? It is needed with the new Django version because we define our models without the 'id' filed.

@brylie brylie merged commit 2af1ad1 into CiviWiki:develop Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants