Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade client-report packages #41

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Upgrade client-report packages #41

merged 2 commits into from
Oct 29, 2024

Conversation

thomassth
Copy link

@thomassth thomassth commented Oct 19, 2024 •
edited
Loading

Only handling packages with vulns:

  • request is not used anywhere
  • d3 upgraded with explicit imports.
    • this make client-report zip small enough to pass tests.

    PASS client-report/dist/report_bundle.5c7ad7da5ccfc0e247e3.js: 166.92KB < 200KB (gzip)

  • webpack slight version bump

Need testing on charts

  • beeswarm
  • drawBoxPlot
  • Seems to be unused
  • correlationMatrix
  • Seems to be unused
  • controls/checkbox
  • participantsGraph/hull
  • commentsGraph (inside participantsGraph)

@thomassth thomassth changed the base branch from edge to edge-civictechto October 19, 2024 05:55
@Zen-cronic
Copy link
Collaborator

thanks @thomassth, syncing with the main branch should fix the current failing tests for now

thomassth
thomassth commented Oct 20, 2024
View reviewed changes
client-report/src/components/boxPlot/drawBoxPlot.js
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BoxPlot seems to be unused?

thomassth
thomassth commented Oct 20, 2024
View reviewed changes
client-report/src/components/correlationMatrix/matrix.js
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matrix seems to be used

@thomassth
Copy link
Author

Checked all components with these tests added

CivicTechTO/polis-storybook#18

@thomassth
Copy link
Author

Also rebased commits, all tests passing

@Zen-cronic Zen-cronic mentioned this pull request Oct 23, 2024
Merged
@Zen-cronic Zen-cronic merged commit 7352b25 into CivicTechTO:edge-civictechto Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zen-cronic Zen-cronic Zen-cronic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomassth @Zen-cronic