Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync latest E2E update to ensure PR from fix #43 passes all tests #45

Merged
merged 2 commits into from
Oct 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/cypress/e2e/client-admin/conversation.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ describe('Conversation: Configure', function () {
cy.wait('@participationInit')

cy.get('[data-view-name="participationView"]').should('be.visible')
cy.get('h2').contains('Test topic closed').should('be.visible')
cy.get('h1').contains('Test topic closed').should('be.visible')
})
})
})
6 changes: 3 additions & 3 deletions e2e/cypress/e2e/client-participation/embeds.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe('Embedded Conversations', function () {

cy.getIframeBody()
.find('.conversationViewHeadline')
.find('h2')
.find('h1')
.should('contain', topic)
.siblings('p')
.should('contain', description)
Expand Down Expand Up @@ -120,7 +120,7 @@ describe('Embedded Conversations', function () {
.find('[data-view-name="root"]')
.should('be.visible')
.find('.conversationViewHeadline')
.find('h2')
.find('h1')
.should('contain', topic)
.siblings('p')
.should('not.exist')
Expand Down Expand Up @@ -160,7 +160,7 @@ describe('Embedded Conversations', function () {
cy.getIframeBody()
.find('[data-view-name="root"]')
.should('be.visible')
.find('.conversationViewHeadline h2')
.find('.conversationViewHeadline h1')
.should('not.exist')
})
})
Expand Down
Loading