Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New candidate card structure #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kingscott
Copy link
Member

Note: This is WIP

Build out new structure for candidate cards.

@pnijjar
Copy link
Collaborator

pnijjar commented Oct 20, 2019

I always get confused by this. When you say this is a WIP do you wish for us to merge it now or to wait until you give further notice? It is a pull request so I presume you want it pulled now, but I can't tell for sure.

My inclination is to not merge until after the election, but if you really want it beforehand then let me know.

@kingscott
Copy link
Member Author

kingscott commented Oct 20, 2019

Sorry for the confusion, but I mean to state that the PR is in fact in progress and is not yet complete. I use the posted, but WIP, PR as a way to track my changes. Upon a completion, and a review (if required) I'll make sure to merge it.

My plan is to get the new card structure out before the election.

Edit: On second thought, maybe it won't get released before the election as I may not have all the info before Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants