Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-453]: Added Multi-Processing support for Data Ingestion Pipeline #34

Conversation

srikanthbachala20
Copy link
Contributor

@srikanthbachala20 srikanthbachala20 commented Jan 2, 2025

Added support for multi-processing in Data Ingestion Pipelines
Ref - https://clarifai.atlassian.net/browse/DEVX-453

Copy link
Contributor

@mogith-pn mogith-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you have tested this in local to ensure it doesn't fail due to race conditions or due to sequence of transformations. Looks good to me.
LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can we add a test to check if the sequence remains correct while using Threadpool. We do have some tests, but all of those checks only the first chunk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sanjaychelliah sanjaychelliah merged commit a91f24a into main Jan 2, 2025
10 checks passed
Copy link
Contributor

@sanjaychelliah sanjaychelliah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants