Languages support + Russian localization #60
Conversation
|
Hi @Norskes, thanks for the PR. It looks good, I only found 2 strings that aren't translated:
If you'd like to take a look and translate these 2 more strings, then doing that in a new PR will probably be easiest for everyone since it has been a while. I'll go ahead and merge this one. |
| 'Welcome to ClassicPress! You will be redirected to the About ClassicPress screen. If not, click <a href="%2$s">here</a>.', | ||
| 'switch-to-classicpress' | ||
| ); | ||
|
|
||
| case 'Welcome to WordPress %1$s. <a href="%2$s">Learn more</a>.': | ||
| return __( | ||
| /* translators: 1: omitted; 2: link to about.php (About ClassicPress screen) */ |
There was a problem hiding this comment.
The "1: omitted" here is just a mistake. I will leave this for a separate PR also, since changing it would break the translations of these strings.
There was a problem hiding this comment.
I'm not sure about this. The original line has 2 variables, but ClassicPress omits the first one. This comment helps translators understand why there is only %2$s variable without %1$s. But I might understand this wrong. I didn't explore the filter source and this override function confuses me a bit as I don't see the passed values there.
There was a problem hiding this comment.
Yes, the original line has 2 variables, so that needs to stay as-is.
I was thinking there is no need to do the same thing in our "re-translated" string, but I guess it doesn't matter. These particular messages only appear very briefly as progress lines when the migration has finished.
Those two strings had wrong text-domain, so the .pot didn't include them. Fixed this in #69 |
Description
Motivation and context
This plugin is one of the main entrance points of ClassicPress for end users. And it contains some quite important warnings that should be absoultely clear. It would be much easier to make first steps if interface switches to a native language. It improves safety + shows some care and friendliness.
Screenshots