Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Replacing Jarsigner with Apksigner #83

Merged
merged 10 commits into from
Apr 12, 2021

Conversation

Dado1513
Copy link
Contributor

@Dado1513 Dado1513 commented Apr 12, 2021

  • Replacing Jarsigner with Apksigner
  • Update README.md with new requirements
  • Add Test case for Apksigner

Description

Replacing JarSigner with Apksigner to sign apps, issue 63

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (e.g., refactoring, documentation, etc.)

Checklist

  • I have read the contributing guidelines
  • I have performed a self-review of my own code (added comments, corrected misspellings etc.)
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation (if appropriate)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

P.S.: sembrava impossibile, ma alla fine ce l'ho fatta.

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #83 (df08618) into master (4b4b369) will not change coverage.
The diff coverage is 97.67%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files          49       49           
  Lines        2448     2448           
  Branches      484      484           
=======================================
  Hits         1904     1904           
  Misses        416      416           
  Partials      128      128           
Impacted Files Coverage Δ
src/obfuscapk/cli.py 88.37% <ø> (ø)
src/obfuscapk/tool.py 97.87% <97.36%> (ø)
src/obfuscapk/main.py 95.45% <100.00%> (ø)
src/obfuscapk/obfuscation.py 83.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4b369...df08618. Read the comment docs.

@ClaudiuGeorgiu
Copy link
Owner

image

@ClaudiuGeorgiu
Copy link
Owner

Come on, @Dado1513, you can do it (or maybe not)!

@Dado1513
Copy link
Contributor Author

image

@ClaudiuGeorgiu
Copy link
Owner

image

README.md Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants