Revamp UI #9
Revamp UI #9
Conversation
|
Thank you!
|
- Remove most constraints, use stack views instead - Remove NoClippingView, which isn't needed when building with Sonoma SDKs and up - Simplify the show/hide code to only hide the stack views themselves, and remove the associated outlets
The system doesn't seem to provide a large image for the warning triangle, so we're getting it from the system Diagnostics Reporter app.
- Window title and body title now mention app name - Some of the text has been reworded, some removed - Elements are reordered
The privacy policy button is hidden alongside the crash log. The window is now narrower.
- Fix email field placeholder not showing, and reword - Make title text size standard
And bold the field labels.
- Updated screenshots - Mention userProvidedDetails POST variable
|
I modeled the UI after the built-in macOS crash reporter; so I went along with their "Show/Hide Details" button, and the way it reveals the details inline: That's also where I moved the privacy policy button, which didn't fit in the button row anymore. A disclosure arrow might make more sense, but might also look less familiar, and make the window feel more cluttered because of how it would stand out. |
|
@Cykelero Alright, fine with me to keep the button that way then. Does the window height setting fit small screens with zoom? Asking because the xib shows a window height of 605 and a content view height of ~660. That should not be a problem, but some of my users send screenshots with UI scaling enabled because of poor eyesight, and only then do I notice how weird some parts can look. Windows with fixed or too large min height values can grow out of the screen bounds. If the window would grow taller than fits a 13" MacBook at largest zoom factor, the "hide details" button could disappear out of the screen at the bottom, making it impossible to find the button to shrink the window again; it's also impossible to move the window higher up by grabbing the title bar to get to the buttons. A more forgivingly auto-shrinking window should work without needing to rearrange buttons or add disclosure buttons. P.S.: feel free to request a review anytime so I get a notification! |
It's now 545 pixels tall at most.
|
That's a good point, I hadn't thought of that! I didn't find how to cap the window height to available screen space using Auto Layout (is that possible) so I shrunk it instead; it's now 545 pixels at most. It should fit nicely in the 2020 MacBook Air's 1024×640 scaled resolution. |
|
That also works :) I guess next it's time for me to replace Travis with GitHub Actions, and maybe check if the PHP script works with CI, too |
This PR completely revamps the crash reporter UI, and adds the ability for the user to provide details about the crash.
The main changes are: