Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtest support (https://github.com/CleanCut/green/issues/111) #167

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

VladV
Copy link
Contributor

@VladV VladV commented Jul 24, 2017

No description provided.

@coveralls
Copy link

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-0.4%) to 99.604% when pulling a676713 on VladV:master into 81b8b86 on CleanCut:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.604% when pulling a676713 on VladV:master into 81b8b86 on CleanCut:master.

@CleanCut CleanCut merged commit 432a938 into CleanCut:master Aug 11, 2017
@CleanCut
Copy link
Owner

Thank you for putting in the time and effort to get this going! It is efforts like yours that keep projects like this alive.

I extended your patch and made it so that if all subtests pass, you get a single test succeeding. Otherwise you get a test failure/error for each subtest that failed/errored. I would rather have a different behavior, but due to unittest's odd choice of implementation, that would be really, really hard to accomplish. I also fixed it so that in both cases the count of tests adds up correctly. And I wrote tests for the new feature. And fixed the cursor-rewinding-a-different-length-than-it-should bug. And some other minor stuff.

If you're interested, you the commit is a302858

@CleanCut
Copy link
Owner

Resolved in 2.11.0 (just released).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants