-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unconditionally cleanup temp folder in poolRunner #173
Conversation
1 similar comment
Unfortunately, that (somewhat perplexingly) breaks skipping tests from setUpClass class methods on Python 3 on macOS. It consistently fails on both Travis and on my MacBook Pro. I think the fact that I couldn't figure out why it broke it is why that seemingly-silly if statement was there in the first place. Lets take another look and see if we can fix the actual problem, instead of leaving temp files around.
|
@CleanCut : I can't help you with that, I have no way to test on MacOS. What about reverting to if sys.platform != 'darwin' or sys.version_info[0] == 2: # pragma: no cover
shutil.rmtree(tempfile.tempdir, ignore_errors=True) as a temporary patch ? |
@althonos Sure, lets do that. I'd prefer actually fixing it for reals somehow, but I'm swamped right now. Lets add a |
1 similar comment
Included in 2.11.2, just released. |
I had to revert this commit in 2.13.1, as it was breaking Green on some setups. Do you want to look at this again with 2.13.1 and see if you still see a buildup of extra temporary directories? |
Hi Nathan,
because of a conditional branch the temporary directories that a
poolRunner
call creates are not properly created in Python 3. When running tests several times, the/tmp
(or equivalent) directory can become cluttered very quickly. I removed theif
branching so that the temporary folder is always removed.